VR: add bind-interfaces to /etc/dnsmasq.d/cloud.conf #10739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10739 +/- ##
=========================================
Coverage 15.17% 15.17%
- Complexity 11332 11333 +1
=========================================
Files 5415 5415
Lines 474893 474893
Branches 57920 57920
=========================================
+ Hits 72046 72049 +3
+ Misses 394792 394790 -2
+ Partials 8055 8054 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13096 |
|
[SF] Trillian Build Failed (tid-13045) |
vishesh92
approved these changes
Apr 18, 2025
There was a problem hiding this comment.
lgtm. Patch works as expected.
Before
$ netstat -ntlp | grep 53
tcp 0 0 0.0.0.0:53 0.0.0.0:* LISTEN 2696/dnsmasq
tcp6 0 0 :::53 :::* LISTEN 2696/dnsmasqAfter
$ netstat -ntlp | grep 53
tcp 0 0 127.0.0.1:53 0.0.0.0:* LISTEN 57227/dnsmasq
tcp 0 0 172.30.0.2:53 0.0.0.0:* LISTEN 57227/dnsmasq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #10733
prior to this change, dnsmasq listens on
0.0.0.0:53, so other services (e.g haproxy) cannot use port 53 of public IPs.with this change, dnsmasq listens only on the guest interface
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?