UI: Update message of load balancer for autoscaling group #10750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10750 +/- ##
=========================================
Coverage 16.02% 16.02%
- Complexity 13128 13129 +1
=========================================
Files 5652 5652
Lines 495991 495998 +7
Branches 60064 60067 +3
=========================================
+ Hits 79476 79486 +10
+ Misses 407648 407643 -5
- Partials 8867 8869 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@weizhouapache , do we consider this a 'fix' for #9587 ? or just a collatoral PR ;) |
This PR is just a clarification that #9587 is not an issue but expected behaviour |
|
to be a fix or not to be a fix, ... certainly marking it as the one! |
DaanHoogland
approved these changes
Apr 18, 2025
Pearl1594
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the description of load balancer rule for autoscaling group.
When the autoscaling group is Enabled, the LB can be updated, including the name, sticky policy, algorithm
But the vm instance cannot be removed from the load balancer rule.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?