Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Updated Endpoint Selector to pick the Cluster in Enabled state (in addition to Host state) #10757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 4.20
Choose a base branch
from
Draft

[WIP] Updated Endpoint Selector to pick the Cluster in Enabled state (in addition to Host state) #10757

wants to merge 1 commit into from

Conversation

sureshanaparti
Copy link
Contributor

Description

Current EndPoint selection checks for Host status Up and and resource_state Enabled, however there is a case where whole Cluster (where Host located is) can be disabled. This PR updates the EndPoint selection query to consider the clusters with allocation state 'Enabled' (in addition to current Host state check - status Up and and resource_state Enabled), which ensures the Host is chosen from Enabled cluster.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.20.1 milestone Apr 21, 2025
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Apr 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.02%. Comparing base (0af887b) to head (e458a41).

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10757   +/-   ##
=========================================
  Coverage     16.02%   16.02%           
- Complexity    13127    13134    +7     
=========================================
  Files          5652     5652           
  Lines        495994   495994           
  Branches      60067    60067           
=========================================
+ Hits          79466    79495   +29     
+ Misses       407668   407627   -41     
- Partials       8860     8872   +12
Flag Coverage Δ
uitests 3.99% <ø> (ø)
unittests 16.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti sureshanaparti changed the title Updated Endpoint Selector to pick the Cluster in Enabled state (in addition to Host state) [WIP] Updated Endpoint Selector to pick the Cluster in Enabled state (in addition to Host state) Apr 21, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13121

@borisstoyanov
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13082)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54961 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10757-t13082-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Member

code lgtm

pod could be disabled as well.
it might be better to check if pod state is checked during resource allocation, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees
No one assigned
Labels
component:storage
Projects
None yet
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.
4 participants
@sureshanaparti @blueorangutan @borisstoyanov @weizhouapache