Thanks to visit codestin.com
Credit goes to github.com

Skip to content

smoke tests: Fix cluster DRS & non-strict host affinity smoke test failures on XenServer / XCP-ng #10761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2025
Merged

smoke tests: Fix cluster DRS & non-strict host affinity smoke test failures on XenServer / XCP-ng #10761

merged 4 commits into from
Apr 26, 2025

Conversation

Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Apr 22, 2025 •
edited
Loading

Description

This PR fixes the consistent test failure noticed on the cluster drs test suite on the 4.19 and 4.20 health check PRs for XenServer/XCP-ng versions 8.0+.
#10668 (comment)
This is because the template used - namely the built-in centos 5.6 template does not have PV drivers installed i.e., xenserver tools, thus migration of the VM fails with the following exception:

2025-04-22 05:13:01,446 DEBUG [c.c.a.m.D.Task] (DirectAgent-428:[ctx-8a11e226]) (logid:b6b3bd33) Seq 2-3585709728317048979: Executing request
2025-04-22 05:13:01,481 WARN  [c.c.h.x.r.XenServer650Resource] (DirectAgent-428:[ctx-8a11e226]) (logid:0348b8ac) Task failed! Task record:                 uuid: 15d12e85-9a6d-0a91-2662-ee82cd6215c2
           nameLabel: Async.VM.pool_migrate
     nameDescription:
   allowedOperations: []
   currentOperations: {}
             created: Tue Apr 22 05:13:01 UTC 2025
            finished: Tue Apr 22 05:13:01 UTC 2025
              status: failure
          residentOn: com.xensource.xenapi.Host@a4064fa5
            progress: 1.0
                type: <none/>
              result:
           errorInfo: [VM_LACKS_FEATURE, OpaqueRef:457e3157-4d65-4041-b6f1-0fe971f57b44]
         otherConfig: {}
           subtaskOf: com.xensource.xenapi.Task@aaf13f6f
            subtasks: []

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[root@ref-trl-8376-x-mol8-pearl-dsilva-marvin ~]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=/marvin/ref-trl-8376-x-Mol8-pearl-dsilva-advanced-cfg -s -a tags=advanced --hypervisor=Xenserver test_cluster_drs.py 
/usr/local/lib/python3.6/site-packages/paramiko/transport.py:32: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography. The next release of cryptography will remove support for Python 3.6.
  from cryptography.hazmat.backends import default_backend

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /marvin/MarvinLogs/Apr_22_2025_05_19_55_ZM6BYI All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
system vms and routers to migrate -- 0
=== Running test_01_condensed_drs_algorithm ===
=== TestName: test_01_condensed_drs_algorithm | Status : SUCCESS ===

system vms and routers to migrate -- 0
=== Running test_02_balanced_drs_algorithm ===
=== TestName: test_02_balanced_drs_algorithm | Status : SUCCESS ===

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Apr 22, 2025
@Pearl1594 Pearl1594 modified the milestones: 4.19.3, 4.20.1 Apr 22, 2025
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Apr 22, 2025
@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@codecov Codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (f055268) to head (39d6d88).
Report is 8 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10761      +/-   ##
============================================
- Coverage     15.16%   15.14%   -0.02%     
- Complexity    11332    11395      +63     
============================================
  Files          5415     5415              
  Lines        474912   477938    +3026     
  Branches      57926    59136    +1210     
============================================
+ Hits          72043    72407     +364     
- Misses       394814   397425    +2611     
- Partials       8055     8106      +51
Flag Coverage Δ
uitests 4.28% <ø> (-0.01%) ⬇️
unittests 15.87% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13128

@Pearl1594 Pearl1594 closed this Apr 22, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Apr 22, 2025
@Pearl1594 Pearl1594 reopened this Apr 22, 2025
@Pearl1594
Copy link
Contributor Author

@blueorangutan test ol8 xcpng82

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

@Pearl1594 Pearl1594 moved this from Done to In Progress in ACS 4.20.1 Apr 22, 2025
@blueorangutan
Copy link

[SF] Trillian test result (tid-13077)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 69267 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10761-t13077-xcpng82.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_non_strict_host_anti_affinity Error 227.52 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 129.96 test_nonstrict_affinity_group.py
test_01_volume_usage Error 102.66 test_usage.py

@Pearl1594 Pearl1594 changed the title smoke test: Fix cluster DRS smoke test failure on XenServer / XCP-ng smoke tests: Fix cluster DRS & non-strict host affinity smoke test failures on XenServer / XCP-ng Apr 23, 2025
@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13138

@Pearl1594
Copy link
Contributor Author

@blueorangutan test ol8 xcpng82

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13093)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 73702 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10761-t13093-xcpng82.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_change_service_offering_for_vm_with_snapshots Failure 381.89 test_vm_snapshots.py

@DaanHoogland DaanHoogland linked an issue Apr 24, 2025 that may be closed by this pull request
Attach volume operation fails on Xenserver when volume name comprises of special characters or emojis #10756
Closed
@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@Pearl1594
Copy link
Contributor Author

[SF] Trillian test result (tid-13093) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 73702 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10761-t13093-xcpng82.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File
test_change_service_offering_for_vm_with_snapshots Failure 381.89 test_vm_snapshots.py

This tests seems to 1 off, as I was able to run it locally fine:

=== TestName: test_change_service_offering_for_vm_with_snapshots | Status : SUCCESS ===

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13163

@Pearl1594
Copy link
Contributor Author

@blueorangutan test matrix

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13131)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13128)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13130)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13129)

@Pearl1594
Copy link
Contributor Author

@blueorangutan test ol8 xcpng82

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13156)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 66619 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10761-t13156-xcpng82.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@Pearl1594
Copy link
Contributor Author

smoke tests passed.

vishesh92
vishesh92 approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and smoke tests are passing

@DaanHoogland DaanHoogland merged commit 9d9737a into 4.19 Apr 26, 2025
44 of 50 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Apr 26, 2025
@DaanHoogland DaanHoogland deleted the smoke-test-drs-xen branch April 26, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees
No one assigned
Labels
component:integration-test Python Warning... Python code Ahead!
Projects
ACS 4.20.1
Status: Done
Milestone
4.19.3
Development

Successfully merging this pull request may close these issues.

Attach volume operation fails on Xenserver when volume name comprises of special characters or emojis
5 participants
@Pearl1594 @blueorangutan @rohityadavcloud @DaanHoogland @vishesh92