Thanks to visit codestin.com
Credit goes to github.com

Skip to content

StorPool notify libvirt when volume is resized #10775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

StorPool notify libvirt when volume is resized #10775

merged 3 commits into from
May 9, 2025
+33 −24

Conversation

slavkap
Copy link
Contributor

@slavkap slavkap commented Apr 24, 2025

Description

Fix of resizing volumes when there is a need to notify libvirt for the change

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

manual and smoke testing

@slavkap
StorPool notify libvirt when volumes is resized
e711702 
Fix of resizing volumes when there is a need to notify libvirt for the
change
@slavkap slavkap changed the title StorPool notify libvirt when volumes is resized StorPool notify libvirt when volume is resized Apr 24, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.00%. Comparing base (603cd84) to head (e711702).

❗ There is a different number of reports uploaded between BASE (603cd84) and HEAD (e711702). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (603cd84) HEAD (e711702)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.20   #10775       +/-   ##
=============================================
- Coverage     16.02%    4.00%   -12.02%     
=============================================
  Files          5652      398     -5254     
  Lines        496021    32532   -463489     
  Branches      60065     5761    -54304     
=============================================
- Hits          79488     1303    -78185     
+ Misses       407665    31080   -376585     
+ Partials       8868      149     -8719
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nvazquez
nvazquez reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - just left a few minor comments

DaanHoogland
DaanHoogland reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

nvazquez
nvazquez approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rohityadavcloud rohityadavcloud added this to the 4.20.1 milestone May 9, 2025
rohityadavcloud
rohityadavcloud approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we wouldn't be able test it - but shall consider @slavkap 's testing

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13313

@DaanHoogland DaanHoogland merged commit 17e062a into apache:4.20 May 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@nvazquez nvazquez nvazquez approved these changes

Assignees
No one assigned
Labels
3rd-party:storpool component:primary-storage component:storage has-3rdparty-components
Projects
None yet
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.
5 participants
@slavkap @rohityadavcloud @blueorangutan @DaanHoogland @nvazquez