ui: show deploy/create button on right info pane #10814
Conversation
Signed-off-by: Abhishek Kumar <[email protected]>
7e77c73 to
8282aa5
Compare
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10814 +/- ##
=========================================
Coverage 16.13% 16.13%
Complexity 13220 13220
=========================================
Files 5651 5652 +1
Lines 496740 496750 +10
Branches 60183 60184 +1
=========================================
+ Hits 80148 80152 +4
+ Misses 407674 407673 -1
- Partials 8918 8925 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
There was a problem hiding this comment.
Pull Request Overview
This PR moves the Deploy/Create and Cancel buttons to the right-hand info panel in the deploy wizards for VM, autoscale groups, and VNF appliances. The changes introduce a new DeployButtons component, update view templates to conditionally render buttons based on device type, and enhance the InfoCard component with a footer slot for the buttons.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/src/views/compute/wizard/DeployButtons.vue | New component that encapsulates deploy button logic and UI |
| ui/src/views/compute/DeployVnfAppliance.vue | Replaces inline buttons with DeployButtons in mobile and desktop layouts |
| ui/src/views/compute/DeployVM.vue | Updates button rendering to use DeployButtons within the info panel and footer slot |
| ui/src/views/compute/CreateAutoScaleVmGroup.vue | Adopts the DeployButtons component for a consistent deploy button UI |
| ui/src/components/view/InfoCard.vue | Adds a footer slot to support embedded DeployButtons in desktop views |
| }, | ||
| deployButtonText: { | ||
| type: String, | ||
| default: () => this.$t('label.create') |
There was a problem hiding this comment.
Avoid using an arrow function to reference 'this' in the default value for the deployButtonText prop since the component instance context may not be bound. Instead, use a regular function to ensure 'this' correctly references the component instance.
| default: () => this.$t('label.create') | |
| default: function () { | |
| return 'label.create'; // Replace with the actual default value or logic | |
| } |
Copilot uses AI. Check for mistakes.
| :deep(.ant-card-body) { padding: 0; | ||
| } |
There was a problem hiding this comment.
| :deep(.ant-card-body) { padding: 0; | |
| } | |
| :deep(.ant-card-body) { | |
| padding: 0; | |
| } |
Description
Move Deploy/Create and Cancel button to right info panel in deploy wizards for VM, autoscale grou, vnf appliance
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?