Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: fix test_hostha_simulator.py and test_outofbandmanagement.py #10815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 4.20
Choose a base branch
from
Open

test: fix test_hostha_simulator.py and test_outofbandmanagement.py #10815

wants to merge 2 commits into from

Conversation

weizhouapache
Copy link
Member

this fixes the test failure below

======================================================================
FAIL: Tests ha resource ownership expiry across multi-mgmt server
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/test/integration/smoke/test_hostha_simulator.py", line 462, in test_ha_multiple_mgmt_server_ownership
    self.fail("Management server failed to turn down or remove fake mgmt server")
AssertionError: Management server failed to turn down or remove fake mgmt server

----------------------------------------------------------------------
Ran 19 tests in 277.481s

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
test: fix test_ha_multiple_mgmt_server_ownership in test_hostha_simul…
7d973e3 
…ator.py

this fixes the test failure below
```
======================================================================
FAIL: Tests ha resource ownership expiry across multi-mgmt server
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/test/integration/smoke/test_hostha_simulator.py", line 462, in test_ha_multiple_mgmt_server_ownership
    self.fail("Management server failed to turn down or remove fake mgmt server")
AssertionError: Management server failed to turn down or remove fake mgmt server

----------------------------------------------------------------------
Ran 19 tests in 277.481s
```
@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels May 5, 2025
@codecov Codecov
Copy link

codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.13%. Comparing base (91c1168) to head (a90f263).
Report is 5 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10815   +/-   ##
=========================================
  Coverage     16.13%   16.13%           
  Complexity    13217    13217           
=========================================
  Files          5649     5651    +2     
  Lines        496703   496740   +37     
  Branches      60179    60183    +4     
=========================================
+ Hits          80129    80149   +20     
- Misses       407656   407668   +12     
- Partials       8918     8923    +5
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 16.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache changed the title test: fix test_ha_multiple_mgmt_server_ownership in test_hostha_simulator.py test: fix test_hostha_simulator.py and test_outofbandmanagement.py May 5, 2025
@weizhouapache
Copy link
Member Author

Cc @Pearl1594

@DaanHoogland
Copy link
Contributor

@weizhouapache , the out-of-bounds failures also happen in the 4.19 GHA (see this job) . Can you backport the fix?

@weizhouapache
Copy link
Member Author

@weizhouapache , the out-of-bounds failures also happen in the 4.19 GHA (see this job) . Can you backport the fix?

@DaanHoogland
it has been fixed by #10805

@weizhouapache weizhouapache marked this pull request as ready for review May 6, 2025 07:18
@DaanHoogland
Copy link
Contributor

@weizhouapache , the out-of-bounds failures also happen in the 4.19 GHA (see this job) . Can you backport the fix?

@DaanHoogland it has been fixed by #10805

ok, I see. So the timeout wasn’t necessary before. Is that something to worry about?

@weizhouapache
Copy link
Member Author

weizhouapache commented May 6, 2025 •
edited
Loading

@weizhouapache , the out-of-bounds failures also happen in the 4.19 GHA (see this job) . Can you backport the fix?

@DaanHoogland it has been fixed by #10805

ok, I see. So the timeout wasn’t necessary before. Is that something to worry about?

@DaanHoogland
I think no, these simulator CI failures should be caused by #9885. we did not face some issues in the testing

these two tests contain some manual database insertation/deletion.
they are not normal behaviours.

@weizhouapache weizhouapache requested a review from Pearl1594 May 7, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees
No one assigned
Labels
component:integration-test Python Warning... Python code Ahead!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weizhouapache @DaanHoogland