Thanks to visit codestin.com
Credit goes to github.com

Skip to content

xenserver: destroy halted vm on expunge #10833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 4.19
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented May 8, 2025

Description

Addresses #9175 (comment)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
Copy link
Contributor Author

shwstppr commented May 8, 2025

@Pearl1594 kindly check. Close this PR and pick changes if needed

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 4.65116% with 41 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (f0838cd) to head (bb60c88).

Files with missing lines Patch % Lines
...wrapper/xenbase/CitrixCleanupVMCommandWrapper.java 5.40% 35 Missing ⚠️
.../main/java/com/cloud/hypervisor/XenServerGuru.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10833      +/-   ##
============================================
- Coverage     15.17%   15.17%   -0.01%     
  Complexity    11339    11339              
============================================
  Files          5414     5415       +1     
  Lines        475185   475228      +43     
  Branches      57991    57997       +6     
============================================
+ Hits          72105    72106       +1     
- Misses       395018   395059      +41     
- Partials       8062     8063       +1     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <4.65%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13299

@weizhouapache
Copy link
Member

@blueorangutan test ol8 xcpng82

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

…or/xenserver/resource/wrapper/xenbase/CitrixCleanupVMCommandWrapper.java
@shwstppr
Copy link
Contributor Author

shwstppr commented May 9, 2025

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13315

@weizhouapache
Copy link
Member

it looks like some vms are not cleaned

[07:28 pr10833-t13241-xcpng82-xs1 ~]# xe vm-list |grep 'power-state ( RO): halted' |wc -l
289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants