Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix for dynamic scaling toggle for instance #11086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for dynamic scaling toggle for instance #11086

wants to merge 2 commits into from
+18 −36

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Jun 25, 2025

Description

This PR fixes #10835 issue.

  1. New capability param is included in listCapabilities response:
"dynamicscalingenabled": true
  1. Using above to toggle Dynamic scaling for Deploy, Edit instance

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87 sudo87 requested a review from shwstppr June 25, 2025 12:25
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (0bd35a5) to head (1564654).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../cloudstack/api/response/CapabilitiesResponse.java 0.00% 3 Missing ⚠️
...k/api/command/user/config/ListCapabilitiesCmd.java 0.00% 1 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11086      +/-   ##
============================================
- Coverage     16.57%   16.57%   -0.01%     
  Complexity    13968    13968              
============================================
  Files          5743     5743              
  Lines        510470   510491      +21     
  Branches      62074    62072       -2     
============================================
- Hits          84615    84611       -4     
- Misses       416393   416424      +31     
+ Partials       9462     9456       -6
Flag Coverage Δ
uitests 3.90% <ø> (+<0.01%) ⬆️
unittests 17.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudo87
Copy link
Collaborator Author

sudo87 commented Jun 25, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13918

shwstppr
shwstppr approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Minor nits

DaanHoogland
DaanHoogland approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@sudo87 , can you add some testing advice?

@sudo87
Copy link
Collaborator Author

sudo87 commented Jul 1, 2025

@sudo87 , can you add some testing advice?

Apologies, missed to add dev testing scenario.

I have followed the steps mentioned in the issue by @shwstppr, to confirm if Dynamic scaling option gets enabled.

  1. Enable config - enable.dynamic.scale.vm if not true already
  2. Create a compute offering with Dynamic Scaling enabled if not present already
  3. Register a template with Dynamic Scaling enabled if not present already
  4. Log in into UI as a normal user and go to deploy VM wizard
  5. Dynamic scaling option under Advanced mode gets Enabled

#10835 (comment)

@sudo87 sudo87 requested a review from borisstoyanov July 2, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees
No one assigned
Labels
component:api component:management-server component:UI status:needs-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: listConfigurations called for normal user in deploy vm wizard
4 participants
@sudo87 @blueorangutan @DaanHoogland @shwstppr