Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: fix orphan db transaction issue #11095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: 4.20
Choose a base branch
from
Draft

server: fix orphan db transaction issue #11095

wants to merge 2 commits into from
+44 −24

Conversation

shwstppr
Copy link
Contributor

Description

Fixes #11058

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (ba0204f) to head (988012f).

Files with missing lines Patch % Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java 31.25% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11095   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13277    13278    +1     
=========================================
  Files          5657     5657           
  Lines        497939   497948    +9     
  Branches      60386    60386           
=========================================
+ Hits          80443    80458   +15     
+ Misses       408532   408526    -6     
  Partials       8964     8964
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.00% <62.06%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vishesh92
vishesh92 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. tested locally. I no longer see the orphaned transaction errors.

DaanHoogland
DaanHoogland approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13939

@shwstppr
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13623)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58801 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11095-t13623-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_04_extract_Iso Failure 128.41 test_iso.py

@DaanHoogland
Copy link
Contributor

I don’t think the iso error is related, invesitgating, and also to verify the absence of the orphaned connection messages;
@blueorangutan test keepEnv

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@shwstppr shwstppr changed the title [WIP] server: fix orphan db transaction issue server: fix orphan db transaction issue Jun 30, 2025
@blueorangutan
Copy link

[SF] Trillian test result (tid-13634)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53807 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11095-t13634-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Contributor

checked on both MSses of a lab env and the message no longer occurs with this change.

@DaanHoogland DaanHoogland added this to the 4.20.2 milestone Jul 1, 2025
@DaanHoogland
Copy link
Contributor

@shwstppr are you satisfied like this or due you want to work on this some more?

@shwstppr
changes in similar code
988012f 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 2, 2025

@DaanHoogland I've updated two more similar code blocks. Will run another round of tests and mark it ready.

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13973

@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 2, 2025

@blueorangutan test

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13657)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57166 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11095-t13657-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

Assignees
No one assigned
Labels
component:database component:storage
Projects
None yet
Milestone
4.20.2
Development

Successfully merging this pull request may close these issues.
4 participants
@shwstppr @blueorangutan @DaanHoogland @vishesh92