ui: allow provisioning backups during instance deploy #11612
Conversation
Add backup offering selection to Deploy VM wizard and assign selected backup offering to the VM after successful deployment. This enables users to choose a backup offering during VM creation, and the VM is automatically associated with the selected offering post-deployment. Signed-off-by: Abhishek Kumar <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11612 +/- ##
============================================
+ Coverage 17.36% 17.39% +0.03%
- Complexity 15237 15286 +49
============================================
Files 5888 5889 +1
Lines 525741 526243 +502
Branches 64164 64256 +92
============================================
+ Hits 91274 91553 +279
- Misses 424167 424355 +188
- Partials 10300 10335 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the VM deployment workflow by allowing users to specify backup offerings and backup schedules during instance creation. The enhancement adds a new backup selection step to the deployment wizard and enables post-deployment automation of backup assignment and schedule creation.
- Adds a new backup selection step to the VM deployment wizard
- Modifies existing backup components to support standalone usage outside of existing VM contexts
- Implements post-deployment actions to automatically assign backup offerings and create schedules
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DeployInstanceBackupSelection.vue | New component for selecting backup offerings and schedules during VM deployment |
| FormSchedule.vue | Modified to support custom submit functions instead of direct API calls |
| BackupSchedule.vue | Modified to support custom delete functions instead of direct API calls |
| DeployVM.vue | Integrated backup selection step and post-deployment backup automation |
| BackupScheduleWizard.vue | Updated to reflect parameter changes in backup components |
| storage.js | Changed section title from "backup" to "backups" |
| InfiniteScrollSelect.vue | Added support for options that can hide their icons |
| Various locale files | Added new translation entries for backup-related labels |
Comments suppressed due to low confidence (1)
ui/src/views/compute/DeployVM.vue:1
- Using timestamp-based IDs ('SCH_' + timestamp) for schedules could lead to collisions if multiple schedules are created rapidly. Consider using a more robust ID generation method or a counter.
// Licensed to the Apache Software Foundation (ASF) under one
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ui/src/views/compute/DeployVM.vue
Outdated
| return | ||
| } | ||
| this.selectedBackupOffering = val | ||
| if (this.backupSchedules && this.backupSchedules.length > 0 && !['nas'].includes(val.provider)) { |
There was a problem hiding this comment.
The hardcoded provider check ['nas'].includes(val.provider) is a magic value that should be documented or extracted to a constant to explain why 'nas' provider is treated differently.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@blueorangutan package |
|
@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Description
This PR enhances the VM deployment workflow by allowing backup offerings and backup schedules to be specified at the time of VM creation.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
deployvm-backup.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?