Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CLOUDSTACK-8215: SAML changing date calculation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2015
Merged

CLOUDSTACK-8215: SAML changing date calculation #71

merged 2 commits into from
Feb 5, 2015

Conversation

eriweb
Copy link
Member

@eriweb eriweb commented Feb 5, 2015

Changed to java.util.Calendar which is a bit more straight forward to use.

Tested and verified that the new certificate is valid for 3 years

@karuturi
Copy link
Member

karuturi commented Feb 5, 2015

Just a personal preference: using Joda DateTime might make it more readable :)

DateTime now = DateTime.now(DateTimeZone.UTC);
certGen.setNotBefore(now.minusDays(1).toDate());
certGen.setNotAfter(now.plusYears(3).toDate());

@eriweb
Copy link
Member Author

eriweb commented Feb 5, 2015

I agree with you :-)
I didn't know we had Joda DateTime available, and with my limited Java experience I didn't want to head out on the journey to introduce it..

I'll rewrite to DateTime and push a new commit

@rohityadavcloud
Copy link
Member

+1 LGTM

@asfgit asfgit merged commit 03e07c4 into apache:4.5 Feb 5, 2015
asfgit pushed a commit that referenced this pull request Feb 5, 2015
@rohityadavcloud
Merge remote-tracking branch 'terbolous/saml2-certvalidity' into 4.5
78b9be0 
This closes #71

Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud
Copy link
Member

Applied on both 4.5 and master. Thanks for fixing this @terbolous !

@asfbot
Copy link

asfbot commented Feb 5, 2015

sebgoa on [email protected] replies:
Rohit, check the review, Rajani made a suggestion and Terbolous is going =
to change his commit.
Please revert and let's wait for an updated commit.
your
feature
please
ticket

@asfbot
Copy link

asfbot commented Feb 5, 2015

Erik Weber on [email protected] replies:
I did update it Sebastien :-)

@asfbot
Copy link

asfbot commented Feb 5, 2015

sebgoa on [email protected] replies:

Ah my bad then (cc @Rohit), I did not see a conversation update about it.

all is good then :)

@asfbot
Copy link

asfbot commented Feb 5, 2015

Rohit Yadav on [email protected] replies:
Hey Sebastien - I merged it only after Erik fixed the DateTime issue
using Joda. Changes look good to me so I did not wait for TravisCI.
g

@asfbot
Copy link

asfbot commented Feb 5, 2015

sebgoa on [email protected] replies:

I love you man, but I think that's bad practice :)
We should always wait for TravisCI to finish, even for a typo.=20

but yes mea culpa, I did not see Erik's update.
it.
going
#71 (comment)
@terbolous !
have
working,
services
Buildhttp://shapeblue.com/iaas-cloud-design-and-build//
frameworkhttp://shapeblue.com/csforge/
Engineeringhttp://shapeblue.com/cloudstack-software-engineering/
Supporthttp://shapeblue.com/cloudstack-infrastructure-support/
Courseshttp://shapeblue.com/cloudstack-training/
intended solely for the use of the individual to whom it is addressed. =
Any views or opinions expressed are solely those of the author and do =
not necessarily represent those of Shape Blue Ltd or related companies. =
If you are not the intended recipient of this email, you must neither =
take any action based upon its contents, nor copy or show it to anyone. =
Please contact the sender if you believe you have received this email in =
error. Shape Blue Ltd is a company incorporated in England & Wales. =
ShapeBlue Services India LLP is a company incorporated in India and is =
operated under license from Shape Blue Ltd. Shape Blue Brasil =
Consultoria Ltda is a company incorporated in Brasil and is operated =
under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company =
registered by The Republic of South Africa and is traded under license =
from Shape Blue Ltd. ShapeBlue is a registered trademark.

@ghost
Copy link

ghost commented Feb 5, 2015

Off topic but I'm not the Rohit you'll are looking for. :)

nvazquez referenced this pull request in shapeblue/cloudstack Jul 24, 2019
@anuragaw @rohityadavcloud
FIX4: Allow ready volumes to be attached to VMs that have never been …
b24dc20 
…started once (#71)

With this patch apache/cloudstack@b766bf7 we started tracking disks in attaching state so that other attach request can fail gracefully. However this missed the case where disks were in allocated state but attach was requested.

For the use case where users want to attach disk in allocated state but not ready, we need to have allocated-attaching transition as well. We must take care of returning to the original state - allocated or ready - when attach request has completed.

For the use case of unstarted vm's the disk must proceed as follows - "Allocated" -> Attaching -> Allocated. When VM is started, the disk is "created" and pool is assigned. For the use case of started VMs it's more trivial and disk proceeds as follows - Ready -> Attaching -> Ready.

Test this by creating a VM with "startvm=false", create a disk and try attaching it in allocated state. It would give an exception on latest 4.11 but will be fixed on this patch.
rohityadavcloud pushed a commit that referenced this pull request Jan 20, 2021
@RitchieVincent @rohityadavcloud
compute: NICs and IPs management (#71)
b140b73 
Adds VM nic/ip management, implement some placement fixes.

Signed-off-by: Rohit Yadav <[email protected]>
nvazquez added a commit that referenced this pull request Mar 24, 2025
@nvazquez
Update IPAM subnet purpose to nat before NAT operations if its differ…
b9a60dd 
…ent (#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eriweb @karuturi @rohityadavcloud @asfbot @asfgit