Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add remove tag to remove acl item method#7750

Merged
DaanHoogland merged 2 commits into
apache:4.18from
shapeblue:aclTagCleanup
Jul 25, 2023
Merged

add remove tag to remove acl item method#7750
DaanHoogland merged 2 commits into
apache:4.18from
shapeblue:aclTagCleanup

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented Jul 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR cleans resource tags when deleting a network acl item.

Fixes: #7744

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

tested by checking the DB contents for the tables network_acl_item vs. resourece_tags

@DaanHoogland DaanHoogland added this to the 4.18.1.0 milestone Jul 18, 2023
@DaanHoogland DaanHoogland linked an issue Jul 18, 2023 that may be closed by this pull request
Tags on network resources are not cleared #7744
Closed
@DaanHoogland

DaanHoogland commented Jul 18, 2023

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 18, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland marked this pull request as ready for review July 18, 2023 13:15
NuxRo
NuxRo approved these changes Jul 18, 2023
View reviewed changes

@NuxRo NuxRo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan

blueorangutan commented Jul 18, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6504

@codecov

codecov Bot commented Jul 18, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7750 (bfbfc14) into 4.18 (d575cae) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               4.18    #7750      +/-   ##
============================================
- Coverage     13.02%   13.02%   -0.01%     
- Complexity     9028     9029       +1     
============================================
  Files          2719     2720       +1     
  Lines        256868   256992     +124     
  Branches      40051    40079      +28     
============================================
+ Hits          33449    33462      +13     
- Misses       219231   219330      +99     
- Partials       4188     4200      +12
Impacted Files Coverage Δ
...a/com/cloud/network/vpc/NetworkACLManagerImpl.java 40.42% <33.33%> (-0.54%) ⬇️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland

DaanHoogland commented Jul 18, 2023

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Jul 18, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jul 19, 2023

Copy link
Copy Markdown

[SF] Trillian test result (tid-7111)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49552 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7750-t7111-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 77.69 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 58.55 test_vm_life_cycle.py

@DaanHoogland

DaanHoogland commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

@shwstppr can you review? both myself and @NuxRo tested.

shwstppr
shwstppr approved these changes Jul 19, 2023
View reviewed changes

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Would be good to have some unit test covering updated methods

@DaanHoogland

DaanHoogland commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Code LGTM. Would be good to have some unit test covering updated methods

I'll have a look but the actual issue involved persistence (would be good to use an in memory db for unit tests)

@DaanHoogland

DaanHoogland commented Jul 24, 2023

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 24, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jul 24, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6547

@DaanHoogland

DaanHoogland commented Jul 24, 2023

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Jul 24, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jul 24, 2023

Copy link
Copy Markdown

[SF] Trillian test result (tid-7146)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43444 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7750-t7146-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 79.67 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 53.36 test_vm_life_cycle.py

@DaanHoogland DaanHoogland merged commit f9b7bcf into apache:4.18 Jul 25, 2023
@DaanHoogland DaanHoogland deleted the aclTagCleanup branch July 25, 2023 08:55
@DaanHoogland DaanHoogland mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@NuxRo NuxRo NuxRo approved these changes

Assignees

No one assigned

Labels

component:networking component:vpc

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

Tags on network resources are not cleared

4 participants

@DaanHoogland @blueorangutan @shwstppr @NuxRo