Add markdownlint with pre-commit#9078
Merged
DaanHoogland merged 1 commit intoMay 28, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9078 +/- ##
=========================================
Coverage 15.28% 15.28%
+ Complexity 11535 11534 -1
=========================================
Files 5425 5425
Lines 474138 474138
Branches 58984 58969 -15
=========================================
+ Hits 72486 72490 +4
+ Misses 393584 393581 -3
+ Partials 8068 8067 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3df8314 to
e4b125b
Compare
Member
Author
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9605 |
DaanHoogland
approved these changes
May 22, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/DavidAnson/markdownlint/tree/main?tab=readme-ov-file#rules--aliases
https://github.com/igorshubovych/markdownlint-cli?tab=readme-ov-file#use-with-pre-commit
Description
This PR adds some checking for Markdown files with pre-commit.
I have added a markdownlint config file which sets a basic standard to start with.
markdownlint is a popular tool and helps improve readability and the portability of the Markdown files.
If needed further clean ups of the Markdown files can be done in future PRs.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran
pre-commit run --all-filesHow did you try to break this feature and the system with this change?