make server threads configurable with server.properties file #9260
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9260 +/- ##
============================================
- Coverage 15.32% 15.32% -0.01%
Complexity 11687 11687
============================================
Files 5459 5459
Lines 477294 477294
Branches 62055 59052 -3003
============================================
- Hits 73140 73138 -2
- Misses 396074 396076 +2
Partials 8080 8080
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9978 |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10321 |
|
@blueorangutan test alma9 kvm-alma9 |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-10805)
|
| private int minThreads = 10; | ||
| private int maxThreads = 500; |
There was a problem hiding this comment.
This is a small a nitpick, but you don't need to initialize these values, as in the properties.getProperty call you already inform these as default.
There was a problem hiding this comment.
will you change this @ahmedali6 ? No big deal if you don't, but if you do, you can also comment out the new properties for the same reason.
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
| # Thread pool configuration | ||
| threads.min=10 | ||
| threads.max=500 |
There was a problem hiding this comment.
minor - too many places we are setting the default value. This could have been a comment
|
@ahmedali6 can you please address the comments and resolve conflicts? |
Description
Fixes: #9161
Types of changes
Feature/Enhancement Scale
How Has This Been Tested?
Tested manually by building and running the server.
How did you try to break this feature and the system with this change?