Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: allow migration of vm with snapshots for vmware #9305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 4.20
Choose a base branch
from
Open

server: allow migration of vm with snapshots for vmware #9305

wants to merge 1 commit into from

Conversation

shwstppr
Copy link
Contributor

Description

Fixes #9061

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.01%. Comparing base (52e7b41) to head (f75e8a8).
Report is 200 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20    #9305   +/-   ##
=========================================
  Coverage     16.01%   16.01%           
- Complexity    12777    12779    +2     
=========================================
  Files          5633     5634    +1     
  Lines        492990   493015   +25     
  Branches      59772    59775    +3     
=========================================
+ Hits          78967    78974    +7     
- Misses       405257   405272   +15     
- Partials       8766     8769    +3
Flag Coverage Δ
uitests 4.02% <ø> (-0.01%) ⬇️
unittests 16.85% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone Jul 1, 2024
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10427

weizhouapache
weizhouapache approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

not tested yet

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10434

@shwstppr
Copy link
Contributor Author

@blueorangutan help

@blueorangutan
Copy link

@shwstppr [SL] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups]
Mgmt OS options: ['ol8', 'ol9', 'alma8', 'alma9', 'suse15', 'centos7', 'centos6', 'rocky8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced)
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar']

@shwstppr
Copy link
Contributor Author

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11237)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50717 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t11237-vmware-70u3.zip
Smoke tests completed. 135 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_06_purge_expunged_vm_background_task Failure 344.84 test_purge_expunged_vms.py
test_02_restore_vm_with_disk_offering Error 62.56 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 63.63 test_restore_vm.py

@shwstppr shwstppr force-pushed the fix-vmw-vmmigratewithsnap branch from 00b8e4e to c7a5186 Compare August 30, 2024 10:30
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10882

@shwstppr
Copy link
Contributor Author

shwstppr commented Sep 2, 2024

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11278)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55622 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t11278-vmware-70u3.zip
Smoke tests completed. 137 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_deployVMInSharedNetwork Error 135.04 test_network.py
test_02_restore_vm_with_disk_offering Error 56.21 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 62.42 test_restore_vm.py

@JoaoJandre JoaoJandre modified the milestones: 4.20.0.0, 4.21.0.0 Sep 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@Pearl1594
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12623

@Pearl1594
Copy link
Contributor

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12529)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60889 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t12529-vmware-70u3.zip
Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 346.36 test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 108.93 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 165.85 test_network.py
test_06_purge_expunged_vm_background_task Failure 395.41 test_purge_expunged_vms.py
test_02_restore_vm_with_disk_offering Error 62.19 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 58.02 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 61.45 test_vm_strict_host_tags.py

@Pearl1594
Copy link
Contributor

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12540)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60881 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t12540-vmware-70u3.zip
Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 339.80 test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 118.11 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 156.17 test_network.py
test_06_purge_expunged_vm_background_task Failure 391.75 test_purge_expunged_vms.py
test_02_restore_vm_with_disk_offering Error 58.11 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 57.98 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 55.27 test_vm_strict_host_tags.py

Pearl1594
Pearl1594 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@rosi-shapeblue
Copy link
Contributor

@blueorangutan test ol8 vmware-70u3 keepEnv

@blueorangutan
Copy link

@rosi-shapeblue a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12765)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 143521 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t12765-vmware-70u3.zip
Smoke tests completed. 132 look OK, 9 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 344.38 test_events_resource.py
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_deploy_more_vms_than_limit_allows Error 163.75 test_deploy_vms_in_parallel.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 115.33 test_network_permissions.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1524.87 test_network.py
test_06_purge_expunged_vm_background_task Failure 405.27 test_purge_expunged_vms.py
test_01_restore_vm Error 3616.12 test_restore_vm.py
test_02_restore_vm_with_disk_offering Error 4.63 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 3616.86 test_restore_vm.py
test_04_restore_vm_allocated_root Error 18.54 test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown Error 26.96 test_restore_vm.py
test_01_deploy_vm_on_specific_host Error 15.69 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 3603.74 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 4.43 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 4.46 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 4.41 test_vm_deployment_planner.py
test_01_migrate_vm_strict_tags_success Error 3604.14 test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure Error 5.87 test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success Error 14.99 test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure Error 3604.32 test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success Error 23.20 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Error 3608.12 test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags Error 23.10 test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags Error 3608.66 test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success Error 9.04 test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success Error 3622.59 test_vm_strict_host_tags.py

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12867)

@rosi-shapeblue
Copy link
Contributor

@blueorangutan test ol8 vmware-70u3 keepEnv

@blueorangutan
Copy link

@rosi-shapeblue a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12868)

@rosi-shapeblue
Copy link
Contributor

@DaanHoogland looks like the build is failing here

@shwstppr
Copy link
Contributor Author

@rosi-shapeblue I guess the build failure was environmental as we've had smoke tests running previously, #9305 (comment). Lets re-package and retry

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13055

rohityadavcloud
rohityadavcloud approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test it

@rohityadavcloud
Copy link
Member

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13189)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60287 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t13189-vmware-70u3.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 333.20 test_events_resource.py
test_01_events_resource Error 333.21 test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 112.75 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 162.69 test_network.py
test_02_restore_vm_with_disk_offering Error 62.25 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 56.16 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 56.59 test_vm_strict_host_tags.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees
No one assigned
Labels
component:api component:migration component:vmware status:needs-testing
Projects
ACS 4.20.1
Status: In Progress
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.

Unable to live migrate VMware VMs with snapshot
8 participants
@shwstppr @blueorangutan @DaanHoogland @Pearl1594 @rosi-shapeblue @rohityadavcloud @weizhouapache @JoaoJandre