ui: improve metrics api use in list views #9825
Conversation
b093e4a to
6af86a7
Compare
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build failed: ✖️ |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #9825 +/- ##
============================================
- Coverage 16.13% 16.13% -0.01%
+ Complexity 13219 13216 -3
============================================
Files 5651 5651
Lines 496748 496749 +1
Branches 60184 60184
============================================
- Hits 80139 80138 -1
- Misses 407686 407687 +1
- Partials 8923 8924 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build failed: ✖️ |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@shwstppr can you please rebase this to 4.20 branch? Thanks - And is it ready for review? |
|
@Pearl1594 this is ready but I would like to know other people's opinions on this. And I feel it would be better to keep this in 4.21 as it would affect almost all major table views cc @rohityadavcloud @NuxRo @andrijapanicsb @weizhouapache @rajujith @borisstoyanov @vladimirpetrov @kiranchavala |
In UI for the list views it is regular API view by default and *Metrics API response may not be needed. *Metrics APIs will take more time to return response so this PR tries to improve the behaviour and enables calling regular API without metrics when metrics toggle is not enabled. Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
59ed2b3 to
c64aa4b
Compare
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@shwstppr you said this should go in v21 but it is still based on the 4.20 branch. I tested in qa and the cluster and host view changes look good. I do not see the zone change though. The clusters field seem to be already only in the metrics view; see https://qa.cloudstack.cloud/simulator/#/zone Did you mean something else? |
|
@DaanHoogland @Pearl1594 I've rebased it to 4.20.today to get some more attention. Tagging some fellow contributors didn't get much interest 😄 I'm okay to move it back to main if you feel this might break things for a dot release. @DaanHoogland for zone, Clusters column has been moved to metrics view now, Before After |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Conflicts needs to be fixed @shwstppr |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Description
In UI for the list views it is regular API view by default and *Metrics API response may not be needed. *Metrics APIs will take more time to return response so this PR tries to improve the behaviour and enables calling regular API without metrics when metrics toggle is not enabled.
Following fields in the corresponding listview have been moved to metrics fields as they're not available in non-metrics response,
clustersstate, hostsinstances, powerstatesTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
metrics-api-improvement.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?