Allow safe numeric widening in Substrait schema compatibility checks#20646
Open
N-Boutaib wants to merge 2 commits intoapache:mainfrom
Open
Allow safe numeric widening in Substrait schema compatibility checks#20646N-Boutaib wants to merge 2 commits intoapache:mainfrom
N-Boutaib wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ensure_field_compatibilityrejects Substrait plans where the base_schema declares a wider numeric type than the table's actual schema (e.g., Int64 in the plan vs Int32 in the table), even though the widening is lossless. This forces consumers to re-implementread_with_schemawithout the check or artificially widen types in the catalog provider.This commonly occurs when an upstream Substrait producer normalizes all numerics to a wider type, while the native catalog preserves the original precision.
What changes are included in this PR?
Adds
is_safe_wideningto accept lossless numeric promotions (signed/unsigned integers, floats).Modifies
ensure_field_compatibilityto allow fields where the table type can be safely widened to the plan type.Are these changes tested?
Yes, unit tests for
is_safe_wideningwith widened types.Are there any user-facing changes?
No.