feat: support unparsing UNNEST as Snowflake FLATTEN table function#20648
Open
goldmedal wants to merge 8 commits intoapache:mainfrom
Open
feat: support unparsing UNNEST as Snowflake FLATTEN table function#20648goldmedal wants to merge 8 commits intoapache:mainfrom
goldmedal wants to merge 8 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
DataFusion's SQL unparser lacked Snowflake dialect support for UNNEST in the FROM clause. Snowflake does not have a native UNNEST table factor — instead it uses the FLATTEN table function to expand arrays. Without this support, logical plans containing Unnest nodes could not be round-tripped to valid Snowflake SQL.
The Datafusion SQL:
It can be transpiled to the equivalent SQL in Snowfalke dialect:
What changes are included in this PR?
SnowflakeDialectwith theunparse_unnest_table_factorimplementation to show how to use it.subquery_alias_inner_query_and_columnsmethod.Are these changes tested?
yes.
Wren AI has been using it in production for a while. Canner#9
Are there any user-facing changes?
yes, new method for the unparser dialect.