feat(sql): unparse array_has as ANY for Postgres#20654
Open
vimeh wants to merge 1 commit intoapache:mainfrom
Open
feat(sql): unparse array_has as ANY for Postgres#20654vimeh wants to merge 1 commit intoapache:mainfrom
vimeh wants to merge 1 commit intoapache:mainfrom
Conversation
PostgreSQL does not have an array_has() function — it uses the `= ANY(array)` operator for array containment checks. Without this dialect override, SQL unparsed for Postgres federation produces invalid syntax. This converts array_has(haystack, needle) to needle = ANY(haystack) in the PostgreSqlDialect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
PostgreSQL does not have an
array_has()function. When the SQL unparser emitsarray_has(haystack, needle)for the Postgres dialect, it produces invalid SQL. The idiomatic equivalent isneedle = ANY(haystack).What changes are included in this PR?
Adds a
scalar_function_to_sql_overridesentry inPostgreSqlDialectthat convertsarray_has(haystack, needle)toneedle = ANY(haystack)viaast::Expr::AnyOp.Are these changes tested?
Yep, with a unit test comparing default vs Postgres dialect output and a roundtrip integration test for
= ANY()in a WHERE clause.Are there any user-facing changes?
No breaking changes.
array_hasexpressions are now unparsed as valid Postgres syntax when usingPostgreSqlDialect.