Add tests for sqllogictest prioritization#20656
Open
alamb wants to merge 1 commit intoapache:mainfrom
Open
Conversation
alamb
commented
Mar 2, 2026
| elapsed: Duration, | ||
| } | ||
|
|
||
| /// TEST PRIORITY |
Contributor
Author
There was a problem hiding this comment.
I refactored all this code and other TestFile logic into a new test_file module
| .filter(|f| f.is_slt_file()) | ||
| .filter(|f| f.check_tpch(options)) | ||
| .filter(|f| f.check_sqlite(options)) | ||
| .filter(|f| !f.relative_path_starts_with(TPCH_PREFIX) || options.include_tpch) |
Contributor
Author
There was a problem hiding this comment.
I separate the Options out of here as they aren't logically part of the Test file
53e0a60 to
31ddadc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Implement suggestions from @kosiew in #20576 (comment):
What changes are included in this PR?
Note that in order to actually write these tests I needed to pull the TestFile and some related logic into its own module
Are these changes tested?
Yes by CI
I also ran the tests locally via
cargo test --profile=ci --test sqllogictestsI also double checked sqllogictests
INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictestsAre there any user-facing changes?