Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: python based catalog and schema provider #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

timsaucer
Copy link
Contributor

@timsaucer timsaucer commented Jun 18, 2025

Which issue does this PR close?

Closes #1091

Rationale for this change

This PR builds on top of #1137 and adds python based schema and catalog providers.

What changes are included in this PR?

Creates wrapper types around python based schema and catalog providers.
Adds checks for when we are going python->rust->python and short circuit to return the python original object rather than wrapper.
Adds unit test

Are there any user-facing changes?

No

Status

Leaving as draft until the following are complete:

  • We need abstract base classes for the catalog and schema providers for users to implement
  • Verify all combinations of default vs user provided python catalog, schema, table providers work in unit tests - this is mostly done
  • Add full end-to-end test of registering custom catalog, schema, table and then do a SQl query against it
  • Update online documentation

@timsaucer
Copy link
Contributor Author

FYI @renato2099 getting the python based providers ended up being a blocking issue for some of my work so I took a stab at implementing it. Please tell me what you think if you have some time.

@timsaucer timsaucer force-pushed the feat/python-catalog-provider branch from dc715fe to 2584075 Compare June 18, 2025 13:35
@timsaucer timsaucer self-assigned this Jun 19, 2025
@timsaucer timsaucer marked this pull request as ready for review June 19, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CatalogProvider and SchemaProvider
2 participants