chore: Remove required approving review count from PRs#66
Merged
Conversation
Member
|
Given this is not globally enforced across repo - LGTM However definitily sound like something we should align eventually |
freakyzoidberg
approved these changes
Jan 8, 2026
Add it back when we have more committers to extend the review bandwidth.
153dd83 to
5210951
Compare
|
I would suggest leaving policy changes open for discussion for a longer period of time than this was. Given the increasing number of attacks on open source software, I tend to pretty strongly support the extra check even though it definitely slows things down at times. Just as a way of giving users of the library additional confidence in our process. |
Member
Author
|
Good point. Although, I tend to relax the setting temporarily and I can foresee to reenable it by the next month. datasketches-rust is not yet to be (generally) production-ready, BTW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add it back when we have more committers to extend the review bandwidth.
cc @leerho @freakyzoidberg
This is a proposal. I hope to cut the new release candidate this week and I'd ask for relaxing this setting for about one month during nominating new committers.