Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[fix](Nereids) set operation children output order not same#24060

Merged
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:fix_set_operation
Sep 14, 2023
Merged

[fix](Nereids) set operation children output order not same#24060
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:fix_set_operation

Conversation

@morrySnow

@morrySnow morrySnow commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

we generate project for all set operation's children to ensure the order of all children are not changed. However, some rules, such as PushDownProjectThroughLimit could remove these projects involuntarily. When it happen, the column order maybe wrong and lead to BE core dump. This PR use a new variable in SetOperation to save the output order of children of set operation. Then the children's output order could be changed and never affect to SetOperation at all.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow morrySnow marked this pull request as ready for review September 8, 2023 06:17
@morrySnow

morrySnow commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@morrySnow

morrySnow commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Sep 8, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.06 seconds
stream load tsv: 550 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162033377 Bytes

@morrySnow

morrySnow commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Sep 8, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.98 seconds
stream load tsv: 543 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162408913 Bytes

@morrySnow

morrySnow commented Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Sep 11, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.84 seconds
stream load tsv: 580 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162372866 Bytes

@morrySnow

morrySnow commented Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Sep 13, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.12 seconds
stream load tsv: 600 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162564840 Bytes

@morrySnow

morrySnow commented Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Sep 13, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.11 seconds
stream load tsv: 597 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162227883 Bytes

@morrySnow

morrySnow commented Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Sep 13, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.08 seconds
stream load tsv: 598 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162234710 Bytes

@morrySnow
[fix](Nereids) set operation children output order not same
16fc6ac 
we generate project for all set operation's children to ensure the order
of all children are not changed. However, some rules, such as
PushDownProjectThroughLimit could remove these projects involuntarily.
When it happen, the column order is wrong and lead to BE core dump.
This PR use a new variable in SetOperation to save the output order of
children of set operation. Then the children's output order could be
changed and never affect to SetOperation at all.
@morrySnow

morrySnow commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Sep 14, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.5 seconds
stream load tsv: 608 seconds loaded 74807831229 Bytes, about 117 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162489596 Bytes

@github-actions

github-actions Bot commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 14, 2023
@github-actions

github-actions Bot commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 46f5988 into apache:master Sep 14, 2023
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Sep 14, 2023
@morrySnow
[fix](Nereids) set operation children output order not same (apache#2…
8065b77 
…4060)

we generate project for all set operation's children to ensure the order
of all children are not changed. However, some rules, such as
PushDownProjectThroughLimit could remove these projects involuntarily.
When it happen, the column order is wrong and lead to BE core dump.
This PR use a new variable in SetOperation to save the output order of
children of set operation. Then the children's output order could be
changed and never affect to SetOperation at all.
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Sep 14, 2023
@morrySnow
[fix](Nereids) set operation children output order not same (apache#2…
b512bcb 
…4060)

we generate project for all set operation's children to ensure the order
of all children are not changed. However, some rules, such as
PushDownProjectThroughLimit could remove these projects involuntarily.
When it happen, the column order is wrong and lead to BE core dump.
This PR use a new variable in SetOperation to save the output order of
children of set operation. Then the children's output order could be
changed and never affect to SetOperation at all.
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 8, 2023
@morrySnow
[fix](Nereids) set operation children output order not same (apache#2…
2450baa 
…4060)

we generate project for all set operation's children to ensure the order
of all children are not changed. However, some rules, such as
PushDownProjectThroughLimit could remove these projects involuntarily.
When it happen, the column order is wrong and lead to BE core dump.
This PR use a new variable in SetOperation to save the output order of
children of set operation. Then the children's output order could be
changed and never affect to SetOperation at all.
@morrySnow morrySnow deleted the fix_set_operation branch October 8, 2023 04:26
@morrySnow morrySnow mentioned this pull request Oct 8, 2023
Merged
xiaokang pushed a commit that referenced this pull request Oct 11, 2023
@morrySnow
[fix](Nereids) set operation children output order not same (#24060) (#…
a8c2947 
…24383)

we generate project for all set operation's children to ensure the order
of all children are not changed. However, some rules, such as
PushDownProjectThroughLimit could remove these projects involuntarily.
When it happen, the column order is wrong and lead to BE core dump.
This PR use a new variable in SetOperation to save the output order of
children of set operation. Then the children's output order could be
changed and never affect to SetOperation at all.
@morrySnow morrySnow mentioned this pull request Nov 13, 2023
Merged
morrySnow added a commit that referenced this pull request Nov 14, 2023
@morrySnow
[fix](Nereids) column pruning under union broken unexpectedly (#26884)
23e2bde 
introduced by PR #24060
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 14, 2023
@morrySnow @seawinde
[fix](Nereids) column pruning under union broken unexpectedly (apache…
697c7a1 
…#26884)

introduced by PR apache#24060
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 15, 2023
@morrySnow @seawinde
[fix](Nereids) column pruning under union broken unexpectedly (apache…
5259cfe 
…#26884)

introduced by PR apache#24060
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morrySnow
[fix](Nereids) column pruning under union broken unexpectedly (apache…
d1ef384 
…#26884)

introduced by PR apache#24060
This was referenced Jun 26, 2026
Closed
Merged
morrySnow added a commit that referenced this pull request Jul 1, 2026
@morrySnow
[fix](set operation) Use regular child output for set operation rules (…
ecda456 
…#64908)

### What problem does this PR solve?

Related PR: #24060, #27628

Problem Summary: Some Nereids rewrite rules mapped set operation outputs
to child outputs by list index. Set operations can carry regulator child
outputs whose order and cardinality differ from the child plan output,
so those rules could read past the child output or rewrite expressions
with the wrong child slot. This change makes one-row union merge and
distinct TopN/Limit pushdown build child mappings from regular child
outputs instead.

### Release note

Fix planner failures or incorrect set operation rewrites when regulated
child outputs differ from child plan outputs.
github-actions Bot pushed a commit that referenced this pull request Jul 1, 2026
@morrySnow
[fix](set operation) Use regular child output for set operation rules (…
a4ab7a9 
…#64908)

### What problem does this PR solve?

Related PR: #24060, #27628

Problem Summary: Some Nereids rewrite rules mapped set operation outputs
to child outputs by list index. Set operations can carry regulator child
outputs whose order and cardinality differ from the child plan output,
so those rules could read past the child output or rewrite expressions
with the wrong child slot. This change makes one-row union merge and
distinct TopN/Limit pushdown build child mappings from regular child
outputs instead.

### Release note

Fix planner failures or incorrect set operation rewrites when regulated
child outputs differ from child plan outputs.
github-actions Bot pushed a commit that referenced this pull request Jul 1, 2026
@morrySnow
[fix](set operation) Use regular child output for set operation rules (…
0a0989e 
…#64908)

### What problem does this PR solve?

Related PR: #24060, #27628

Problem Summary: Some Nereids rewrite rules mapped set operation outputs
to child outputs by list index. Set operations can carry regulator child
outputs whose order and cardinality differ from the child plan output,
so those rules could read past the child output or rewrite expressions
with the wrong child slot. This change makes one-row union merge and
distinct TopN/Limit pushdown build child mappings from regular child
outputs instead.

### Release note

Fix planner failures or incorrect set operation rewrites when regulated
child outputs differ from child plan outputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwener jackwener jackwener approved these changes
@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morrySnow @doris-robot @jackwener @starocean999 @xiaokang @yiguolei