Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[enhancement](230) print max version and spec version when -230 happe… #26854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaokang merged 1 commit into from
Nov 13, 2023
+8 −6
Merged

[enhancement](230) print max version and spec version when -230 happe… #26854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions be/src/olap/tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,10 +857,14 @@ Status Tablet::capture_consistent_versions(const Version& spec_version,
// if version_path is null, it may be a compaction check logic.
// so to avoid print too many logs.
if (version_path != nullptr) {
LOG(WARNING) << "tablet:" << full_name()
<< ", version already has been merged. spec_version: " << spec_version;
LOG(WARNING) << "tablet:" << tablet_id()
<< ", version already has been merged. spec_version: " << spec_version
<< ", max_version: " << max_version_unlocked();
}
status = Status::Error<VERSION_ALREADY_MERGED>("missed_versions is empty");
status = Status::Error<VERSION_ALREADY_MERGED>(
"missed_versions is empty, spec_version "
"{}, max_version {}, tablet_id {}",
spec_version.second, max_version_unlocked().second, tablet_id());
} else {
if (version_path != nullptr) {
LOG(WARNING) << "status:" << status << ", tablet:" << full_name()
Expand Down
4 changes: 1 addition & 3 deletions be/src/vec/exec/scan/new_olap_scanner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,7 @@ Status NewOlapScanner::init() {
auto st = _tablet->capture_rs_readers(rd_version, &read_source.rs_splits);
if (!st.ok()) {
LOG(WARNING) << "fail to init reader.res=" << st;
return Status::InternalError(
"failed to initialize storage reader. tablet_id={} : {}",
_tablet->tablet_id(), st.to_string());
return st;
}
}
if (!_state->skip_delete_predicate()) {
Expand Down