Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[compile](gcc) fix gcc compile error#26863

Merged
yiguolei merged 1 commit into
apache:branch-2.0from
shuke987:1113
Nov 13, 2023
Merged

[compile](gcc) fix gcc compile error#26863
yiguolei merged 1 commit into
apache:branch-2.0from
shuke987:1113

Conversation

@shuke987

@shuke987 shuke987 commented Nov 13, 2023

Copy link
Copy Markdown
Collaborator

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@shuke987

shuke987 commented Nov 13, 2023

Copy link
Copy Markdown
Collaborator Author

run buildall

@github-actions

github-actions Bot commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actions Bot commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Nov 13, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.34% (7964/20770)
Line Coverage: 30.20% (64644/214038)
Region Coverage: 29.27% (33329/113866)
Branch Coverage: 25.09% (17129/68260)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c9d860fa015b2d3d775040c47529b9a69aef26c3_c9d860fa015b2d3d775040c47529b9a69aef26c3/report/index.html

wm1581066
wm1581066 approved these changes Nov 13, 2023
View reviewed changes

@wm1581066 wm1581066 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot

doris-robot commented Nov 13, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.34 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162711861 Bytes

@yiguolei yiguolei merged commit e1574ed into apache:branch-2.0 Nov 13, 2023
@shuke987 shuke987 deleted the 1113 branch November 13, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hello-stephen hello-stephen hello-stephen approved these changes
+1 more reviewer
@wm1581066 wm1581066 wm1581066 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dev/2.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shuke987 @doris-robot @hello-stephen @wm1581066 @yiguolei