Codestin Search App

jacktengg · 2023-11-21T06:40:01Z

Proposed changes

Issue Number: close #xxx

Reproduce:

drop table if exists test_eq_for_null_nullable2;
create table test_eq_for_null_nullable2(
     k1 int 
     ) distributed by hash(k1) properties("replication_num"="1");

 insert into test_eq_for_null_nullable2 values 
        (null),(0),(1),(2),(3);

select * from test_eq_for_null_nullable2 where k1 <=> 1;

DCHECK failure:

F20231121 00:33:47.050846 3869694 olap_utils.h:157] Check failed: false Function Name: eq_for_null
*** Check failure stack trace: ***
F20231121 00:33:47.050851 3869700 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051256 3869693 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051450 3869696 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051481 3869695 olap_utils.h:157] Check failed: false Function Name: eq_for_null
*** Check failure stack trace: ***
F20231121 00:33:47.050851 3869700 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051256 3869693 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051450 3869696 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051481 3869695 olap_utils.h:157] Check failed: false Function Name: eq_for_null
*** Check failure stack trace: ***
F20231121 00:33:47.050851 3869700 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051256 3869693 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051450 3869696 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051481 3869695 olap_utils.h:157] Check failed: false Function Name: eq_for_null
*** Check failure stack trace: ***
F20231121 00:33:47.050851 3869700 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051256 3869693 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051450 3869696 olap_utils.h:157] Check failed: false Function Name: eq_for_nullF20231121 00:33:47.051481 3869695 olap_utils.h:157] Check failed: false Function Name: eq_for_null
*** Check failure stack trace: ***
    @     0x563195b19936  google::LogMessage::SendToLog()
    @     0x563195b19936  google::LogMessage::SendToLog()
    @     0x563195b19936  google::LogMessage::SendToLog()
    @     0x563195b19936  google::LogMessage::SendToLog()
    @     0x563195b19936  google::LogMessage::SendToLog()
    @     0x563195b15f00  google::LogMessage::Flush()
    @     0x563195b15f00  google::LogMessage::Flush()
    @     0x563195b15f00  google::LogMessage::Flush()
    @     0x563195b15f00  google::LogMessage::Flush()
    @     0x563195b15f00  google::LogMessage::Flush()
    @     0x563195b1a179  google::LogMessageFatal::~LogMessageFatal()
    @     0x563195b1a179  google::LogMessageFatal::~LogMessageFatal()
    @     0x563195b1a179  google::LogMessageFatal::~LogMessageFatal()
    @     0x563195b1a179  google::LogMessageFatal::~LogMessageFatal()
    @     0x563195b1a179  google::LogMessageFatal::~LogMessageFatal()
    @     0x5631836eda98  doris::to_olap_filter_type()
    @     0x5631836eda98  doris::to_olap_filter_type()
    @     0x5631836eda98  doris::to_olap_filter_type()
    @     0x5631836eda98  doris::to_olap_filter_type()
    @     0x5631836eda98  doris::to_olap_filter_type()
    @     0x563183713fc1  doris::vectorized::VScanNode::_change_value_range<>()
    @     0x563183713fc1  doris::vectorized::VScanNode::_change_value_range<>()
    @     0x563183713fc1  doris::vectorized::VScanNode::_change_value_range<>()
    @     0x563183713fc1  doris::vectorized::VScanNode::_change_value_range<>()
    @     0x563183713fc1  doris::vectorized::VScanNode::_change_value_range<>()
    @     0x56318370729f  doris::vectorized::VScanNode::_normalize_noneq_binary_predicate<>()
    @     0x56318370729f  doris::vectorized::VScanNode::_normalize_noneq_binary_predicate<>()
    @     0x563183637af0  _ZZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS0_5VExprEEPNS0_12VExprContextERS4_ENK3$_1clINS_16ColumnValueRangeILNS_13PrimitiveTypeE5EEEEEDaRT_
    @     0x563183637af0  _ZZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS0_5VExprEEPNS0_12VExprContextERS4_ENK3$_1clINS_16ColumnValueRangeILNS_13PrimitiveTypeE5EEEEEDaRT_
    @     0x56318370729f  doris::vectorized::VScanNode::_normalize_noneq_binary_predicate<>()
    @     0x563183636b5d  std::__invoke_impl<>()
    @     0x56318370729f  doris::vectorized::VScanNode::_normalize_noneq_binary_predicate<>()
    @     0x56318370729f  doris::vectorized::VScanNode::_normalize_noneq_binary_predicate<>()
    @     0x563183636b5d  std::__invoke_impl<>()
    @     0x563183637af0  _ZZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS0_5VExprEEPNS0_12VExprContextERS4_ENK3$_1clINS_16ColumnValueRangeILNS_13PrimitiveTypeE5EEEEEDaRT_
    @     0x563183636b0d  std::__invoke<>()
    @     0x563183637af0  _ZZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS0_5VExprEEPNS0_12VExprContextERS4_ENK3$_1clINS_16ColumnValueRangeILNS_13PrimitiveTypeE5EEEEEDaRT_
    @     0x563183637af0  _ZZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS0_5VExprEEPNS0_12VExprContextERS4_ENK3$_1clINS_16ColumnValueRangeILNS_13PrimitiveTypeE5EEEEEDaRT_
    @     0x563183636b0d  std::__invoke<>()
    @     0x563183636b5d  std::__invoke_impl<>()
    @     0x5631836323ad  std::__detail::__variant::__gen_vtable_impl<>::__visit_invoke()
    @     0x563183636b5d  std::__invoke_impl<>()
    @     0x563183636b5d  std::__invoke_impl<>()
    @     0x5631836323ad  std::__detail::__variant::__gen_vtable_impl<>::__visit_invoke()
    @     0x563183636b0d  std::__invoke<>()
    @     0x5631836322ca  _ZSt10__do_visitINSt8__detail9__variant21__deduce_visit_resultIvEEZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS5_5VExprEEPNS5_12VExprContextERS9_E3$_1JRSt7variantIJNS4_16ColumnValueRangeILNS4_13PrimitiveTypeE3EEENSH_ILSI_4EEENSH_ILSI_5EEENSH_ILSI_6EEENSH_ILSI_7EEENSH_ILSI_15EEENSH_ILSI_10EEENSH_ILSI_23EEENSH_ILSI_11EEENSH_ILSI_25EEENSH_ILSI_12EEENSH_ILSI_26EEENSH_ILSI_20EEENSH_ILSI_2EEENSH_ILSI_19EEENSH_ILSI_28EEENSH_ILSI_29EEENSH_ILSI_30EEENSH_ILSI_35EEEEEEEDcOT0_DpOT1_
    @     0x563183636b0d  std::__invoke<>()
    @     0x5631836322ca  _ZSt10__do_visitINSt8__detail9__variant21__deduce_visit_resultIvEEZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS5_5VExprEEPNS5_12VExprContextERS9_E3$_1JRSt7variantIJNS4_16ColumnValueRangeILNS4_13PrimitiveTypeE3EEENSH_ILSI_4EEENSH_ILSI_5EEENSH_ILSI_6EEENSH_ILSI_7EEENSH_ILSI_15EEENSH_ILSI_10EEENSH_ILSI_23EEENSH_ILSI_11EEENSH_ILSI_25EEENSH_ILSI_12EEENSH_ILSI_26EEENSH_ILSI_20EEENSH_ILSI_2EEENSH_ILSI_19EEENSH_ILSI_28EEENSH_ILSI_29EEENSH_ILSI_30EEENSH_ILSI_35EEEEEEEDcOT0_DpOT1_
    @     0x563183636b0d  std::__invoke<>()
    @     0x5631836323ad  std::__detail::__variant::__gen_vtable_impl<>::__visit_invoke()
    @     0x56318362b213  _ZSt5visitIZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS1_5VExprEEPNS1_12VExprContextERS5_E3$_1JRSt7variantIJNS0_16ColumnValueRangeILNS0_13PrimitiveTypeE3EEENSD_ILSE_4EEENSD_ILSE_5EEENSD_ILSE_6EEENSD_ILSE_7EEENSD_ILSE_15EEENSD_ILSE_10EEENSD_ILSE_23EEENSD_ILSE_11EEENSD_ILSE_25EEENSD_ILSE_12EEENSD_ILSE_26EEENSD_ILSE_20EEENSD_ILSE_2EEENSD_ILSE_19EEENSD_ILSE_28EEENSD_ILSE_29EEENSD_ILSE_30EEENSD_ILSE_35EEEEEEEDcOT_DpOT0_
    @     0x56318362b213  _ZSt5visitIZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS1_5VExprEEPNS1_12VExprContextERS5_E3$_1JRSt7variantIJNS0_16ColumnValueRangeILNS0_13PrimitiveTypeE3EEENSD_ILSE_4EEENSD_ILSE_5EEENSD_ILSE_6EEENSD_ILSE_7EEENSD_ILSE_15EEENSD_ILSE_10EEENSD_ILSE_23EEENSD_ILSE_11EEENSD_ILSE_25EEENSD_ILSE_12EEENSD_ILSE_26EEENSD_ILSE_20EEENSD_ILSE_2EEENSD_ILSE_19EEENSD_ILSE_28EEENSD_ILSE_29EEENSD_ILSE_30EEENSD_ILSE_35EEEEEEEDcOT_DpOT0_
    @     0x5631836323ad  std::__detail::__variant::__gen_vtable_impl<>::__visit_invoke()
    @     0x5631836323ad  std::__detail::__variant::__gen_vtable_impl<>::__visit_invoke()
    @     0x5631836322ca  _ZSt10__do_visitINSt8__detail9__variant21__deduce_visit_resultIvEEZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS5_5VExprEEPNS5_12VExprContextERS9_E3$_1JRSt7variantIJNS4_16ColumnValueRangeILNS4_13PrimitiveTypeE3EEENSH_ILSI_4EEENSH_ILSI_5EEENSH_ILSI_6EEENSH_ILSI_7EEENSH_ILSI_15EEENSH_ILSI_10EEENSH_ILSI_23EEENSH_ILSI_11EEENSH_ILSI_25EEENSH_ILSI_12EEENSH_ILSI_26EEENSH_ILSI_20EEENSH_ILSI_2EEENSH_ILSI_19EEENSH_ILSI_28EEENSH_ILSI_29EEENSH_ILSI_30EEENSH_ILSI_35EEEEEEEDcOT0_DpOT1_
    @     0x5631836322ca  _ZSt10__do_visitINSt8__detail9__variant21__deduce_visit_resultIvEEZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS5_5VExprEEPNS5_12VExprContextERS9_E3$_1JRSt7variantIJNS4_16ColumnValueRangeILNS4_13PrimitiveTypeE3EEENSH_ILSI_4EEENSH_ILSI_5EEENSH_ILSI_6EEENSH_ILSI_7EEENSH_ILSI_15EEENSH_ILSI_10EEENSH_ILSI_23EEENSH_ILSI_11EEENSH_ILSI_25EEENSH_ILSI_12EEENSH_ILSI_26EEENSH_ILSI_20EEENSH_ILSI_2EEENSH_ILSI_19EEENSH_ILSI_28EEENSH_ILSI_29EEENSH_ILSI_30EEENSH_ILSI_35EEEEEEEDcOT0_DpOT1_
    @     0x5631836322ca  _ZSt10__do_visitINSt8__detail9__variant21__deduce_visit_resultIvEEZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS5_5VExprEEPNS5_12VExprContextERS9_E3$_1JRSt7variantIJNS4_16ColumnValueRangeILNS4_13PrimitiveTypeE3EEENSH_ILSI_4EEENSH_ILSI_5EEENSH_ILSI_6EEENSH_ILSI_7EEENSH_ILSI_15EEENSH_ILSI_10EEENSH_ILSI_23EEENSH_ILSI_11EEENSH_ILSI_25EEENSH_ILSI_12EEENSH_ILSI_26EEENSH_ILSI_20EEENSH_ILSI_2EEENSH_ILSI_19EEENSH_ILSI_28EEENSH_ILSI_29EEENSH_ILSI_30EEENSH_ILSI_35EEEEEEEDcOT0_DpOT1_
    @     0x56318362b213  _ZSt5visitIZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS1_5VExprEEPNS1_12VExprContextERS5_E3$_1JRSt7variantIJNS0_16ColumnValueRangeILNS0_13PrimitiveTypeE3EEENSD_ILSE_4EEENSD_ILSE_5EEENSD_ILSE_6EEENSD_ILSE_7EEENSD_ILSE_15EEENSD_ILSE_10EEENSD_ILSE_23EEENSD_ILSE_11EEENSD_ILSE_25EEENSD_ILSE_12EEENSD_ILSE_26EEENSD_ILSE_20EEENSD_ILSE_2EEENSD_ILSE_19EEENSD_ILSE_28EEENSD_ILSE_29EEENSD_ILSE_30EEENSD_ILSE_35EEEEEEEDcOT_DpOT0_
    @     0x56318362b213  _ZSt5visitIZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS1_5VExprEEPNS1_12VExprContextERS5_E3$_1JRSt7variantIJNS0_16ColumnValueRangeILNS0_13PrimitiveTypeE3EEENSD_ILSE_4EEENSD_ILSE_5EEENSD_ILSE_6EEENSD_ILSE_7EEENSD_ILSE_15EEENSD_ILSE_10EEENSD_ILSE_23EEENSD_ILSE_11EEENSD_ILSE_25EEENSD_ILSE_12EEENSD_ILSE_26EEENSD_ILSE_20EEENSD_ILSE_2EEENSD_ILSE_19EEENSD_ILSE_28EEENSD_ILSE_29EEENSD_ILSE_30EEENSD_ILSE_35EEEEEEEDcOT_DpOT0_
    @     0x56318362b213  _ZSt5visitIZN5doris10vectorized9VScanNode20_normalize_predicateERKSt10shared_ptrINS1_5VExprEEPNS1_12VExprContextERS5_E3$_1JRSt7variantIJNS0_16ColumnValueRangeILNS0_13PrimitiveTypeE3EEENSD_ILSE_4EEENSD_ILSE_5EEENSD_ILSE_6EEENSD_ILSE_7EEENSD_ILSE_15EEENSD_ILSE_10EEENSD_ILSE_23EEENSD_ILSE_11EEENSD_ILSE_25EEENSD_ILSE_12EEENSD_ILSE_26EEENSD_ILSE_20EEENSD_ILSE_2EEENSD_ILSE_19EEENSD_ILSE_28EEENSD_ILSE_29EEENSD_ILSE_30EEENSD_ILSE_35EEEEEEEDcOT_DpOT0_
    @     0x563183626d78  doris::vectorized::VScanNode::_normalize_predicate()
    @     0x563183626d78  doris::vectorized::VScanNode::_normalize_predicate()
    @     0x563183626d78  doris::vectorized::VScanNode::_normalize_predicate()
    @     0x563183626d78  doris::vectorized::VScanNode::_normalize_predicate()
    @     0x563183626d78  doris::vectorized::VScanNode::_normalize_predicate()
    @     0x563183624fa8  doris::vectorized::VScanNode::_normalize_conjuncts()
    @     0x563183624fa8  doris::vectorized::VScanNode::_normalize_conjuncts()
    @     0x563183624fa8  doris::vectorized::VScanNode::_normalize_conjuncts()
    @     0x563183624fa8  doris::vectorized::VScanNode::_normalize_conjuncts()
    @     0x5631832a5294  doris::vectorized::VScanNode::_process_conjuncts()
    @     0x563183624fa8  doris::vectorized::VScanNode::_normalize_conjuncts()
    @     0x5631832a5294  doris::vectorized::VScanNode::_process_conjuncts()
    @     0x5631832a5294  doris::vectorized::VScanNode::_process_conjuncts()
    @     0x5631832a5294  doris::vectorized::VScanNode::_process_conjuncts()
    @     0x563183382c2c  doris::vectorized::NewOlapScanNode::_process_conjuncts()
    @     0x5631832a5294  doris::vectorized::VScanNode::_process_conjuncts()
    @     0x563183382c2c  doris::vectorized::NewOlapScanNode::_process_conjuncts()
    @     0x563183616a63  doris::vectorized::VScanNode::alloc_resource()
    @     0x563183616a63  doris::vectorized::VScanNode::alloc_resource()
    @     0x563183382c2c  doris::vectorized::NewOlapScanNode::_process_conjuncts()
    @     0x563183382c2c  doris::vectorized::NewOlapScanNode::_process_conjuncts()
    @     0x563183382c2c  doris::vectorized::NewOlapScanNode::_process_conjuncts()
    @     0x563183616a63  doris::vectorized::VScanNode::alloc_resource()
    @     0x563194b1b449  doris::pipeline::StreamingOperator<>::open()
    @     0x563183616a63  doris::vectorized::VScanNode::alloc_resource()
    @     0x563183616a63  doris::vectorized::VScanNode::alloc_resource()
    @     0x563194b1b449  doris::pipeline::StreamingOperator<>::open()
    @     0x563194b1b449  doris::pipeline::StreamingOperator<>::open()
    @     0x56319591f6d0  doris::pipeline::PipelineTask::_open()
    @     0x56319591f6d0  doris::pipeline::PipelineTask::_open()
    @     0x563194b1b449  doris::pipeline::StreamingOperator<>::open()
    @     0x563194b1b449  doris::pipeline::StreamingOperator<>::open()
    @     0x5631959202ae  doris::pipeline::PipelineTask::execute()
    @     0x56319591f6d0  doris::pipeline::PipelineTask::_open()
    @     0x5631959202ae  doris::pipeline::PipelineTask::execute()
    @     0x56319591f6d0  doris::pipeline::PipelineTask::_open()
    @     0x56319591f6d0  doris::pipeline::PipelineTask::_open()
    @     0x563195ae411a  doris::pipeline::TaskScheduler::_do_work()
    @     0x5631959202ae  doris::pipeline::PipelineTask::execute()
    @     0x563195ae411a  doris::pipeline::TaskScheduler::_do_work()
    @     0x5631959202ae  doris::pipeline::PipelineTask::execute()
    @     0x5631959202ae  doris::pipeline::PipelineTask::execute()
    @     0x563195af45d9  std::__invoke_impl<>()
    @     0x563195ae411a  doris::pipeline::TaskScheduler::_do_work()
    @     0x563195af45d9  std::__invoke_impl<>()
    @     0x563195ae411a  doris::pipeline::TaskScheduler::_do_work()
    @     0x563195ae411a  doris::pipeline::TaskScheduler::_do_work()
    @     0x563195af4445  std::__invoke<>()
    @     0x563195af4445  std::__invoke<>()
    @     0x563195af45d9  std::__invoke_impl<>()
    @     0x563195af45d9  std::__invoke_impl<>()
    @     0x563195af45d9  std::__invoke_impl<>()
    @     0x563195af43b4  _ZNSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS2_mEE6__callIvJEJLm0ELm1EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
    @     0x563195af43b4  _ZNSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS2_mEE6__callIvJEJLm0ELm1EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
    @     0x563195af4445  std::__invoke<>()
    @     0x563195af4445  std::__invoke<>()
    @     0x563195af4445  std::__invoke<>()
    @     0x563195af421e  std::_Bind<>::operator()<>()
    @     0x563195af421e  std::_Bind<>::operator()<>()
    @     0x563195af43b4  _ZNSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS2_mEE6__callIvJEJLm0ELm1EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
    @     0x563195af43b4  _ZNSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS2_mEE6__callIvJEJLm0ELm1EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
    @     0x563195af4135  std::__invoke_impl<>()
    @     0x563195af43b4  _ZNSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS2_mEE6__callIvJEJLm0ELm1EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
    @     0x563195af4135  std::__invoke_impl<>()
    @     0x563195af421e  std::_Bind<>::operator()<>()
    @     0x563195af40d5  _ZSt10__invoke_rIvRSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS3_mEEJEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESB_E4typeEOSC_DpOSD_
    @     0x563195af421e  std::_Bind<>::operator()<>()
    @     0x563195af40d5  _ZSt10__invoke_rIvRSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS3_mEEJEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESB_E4typeEOSC_DpOSD_
    @     0x563195af421e  std::_Bind<>::operator()<>()
    @     0x563195af3ddd  std::_Function_handler<>::_M_invoke()
    @     0x563195af4135  std::__invoke_impl<>()
    @     0x56316493a0c3  std::function<>::operator()()
    @     0x563195af4135  std::__invoke_impl<>()
    @     0x56316824b199  doris::FunctionRunnable::run()
    @     0x563195af3ddd  std::_Function_handler<>::_M_invoke()
    @     0x563195af4135  std::__invoke_impl<>()
    @     0x563168236fae  doris::ThreadPool::dispatch_thread()
    @     0x56316493a0c3  std::function<>::operator()()
    @     0x563195af40d5  _ZSt10__invoke_rIvRSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS3_mEEJEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESB_E4typeEOSC_DpOSD_
    @     0x56316825da04  std::__invoke_impl<>()
*** Query id: e100244688b14986-95b903eddbb5bb5a ***
*** tablet id: 0 ***
*** Aborted at 1700498030 (unix time) try "date -d @1700498030" if you are using GNU date ***
*** Current BE git commitID: bd2e8239f8 ***
*** SIGABRT unknown detail explain (@0x43c003b0a7a) received by PID 3869306 (TID 3869700 OR 0x7ebb8e0f7700) from PID 3869306; stack trace: ***
    @     0x563195af40d5  _ZSt10__invoke_rIvRSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS3_mEEJEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESB_E4typeEOSC_DpOSD_
    @     0x56316824b199  doris::FunctionRunnable::run()
    @     0x563168236fae  doris::ThreadPool::dispatch_thread()
    @     0x563195af40d5  _ZSt10__invoke_rIvRSt5_BindIFMN5doris8pipeline13TaskSchedulerEFvmEPS3_mEEJEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESB_E4typeEOSC_DpOSD_
    @     0x563195af3ddd  std::_Function_handler<>::_M_invoke()
    @     0x56316825da04  std::__invoke_impl<>()
    @     0x563195af3ddd  std::_Function_handler<>::_M_invoke()
    @     0x56316493a0c3  std::function<>::operator()()
    @     0x56316493a0c3  std::function<>::operator()()
    @     0x56316824b199  doris::FunctionRunnable::run()
    @     0x563195af3ddd  std::_Function_handler<>::_M_invoke()
    @     0x56316824b199  doris::FunctionRunnable::run()
    @     0x563168236fae  doris::ThreadPool::dispatch_thread()
    @     0x56316493a0c3  std::function<>::operator()()
    @     0x563168236fae  doris::ThreadPool::dispatch_thread()
    @     0x56316825da04  std::__invoke_impl<>()
    @     0x56316824b199  doris::FunctionRunnable::run()
    @     0x56316825da04  std::__invoke_impl<>()
    @     0x563168236fae  doris::ThreadPool::dispatch_thread()
    @     0x56316825da04  std::__invoke_impl<>()
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/tengjianping/doris-39/be/src/common/signal_handler.h:417
 1# 0x00007FF5E9C1F400 in /lib64/libc.so.6
 2# __GI_raise in /lib64/libc.so.6
 3# __GI_abort in /lib64/libc.so.6
 4# 0x0000563195B2414D in /mnt/disk2/tengjianping/doris-39/output/be/lib/doris_be
 5# 0x0000563195B1645A in /mnt/disk2/tengjianping/doris-39/output/be/lib/doris_be
 6# google::LogMessage::SendToLog() in /mnt/disk2/tengjianping/doris-39/output/be/lib/doris_be
 7# google::LogMessage::Flush() in /mnt/disk2/tengjianping/doris-39/output/be/lib/doris_be
 8# google::LogMessageFatal::~LogMessageFatal() in /mnt/disk2/tengjianping/doris-39/output/be/lib/doris_be
 9# doris::to_olap_filter_type(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) in /mnt/disk2/tengjianping/doris-39/output/be/lib/doris_be
10# doris::Status doris::vectorized::VScanNode::_change_value_range<false, (doris::PrimitiveType)5, void (doris::ColumnValueRange<(doris::PrimitiveType)5>&, doris::SQLFilterOp, int*)>(doris::ColumnValueRange<(doris::PrimitiveType)5>&, void*, void ( const&)(doris::ColumnValueRange<(doris::PrimitiveType)5>&, doris::SQLFilterOp, int*), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int) at /mnt/disk2/tengjianping/doris-39/be/src/vec/exec/scan/vscan_node.cpp:1232
11# doris::Status doris::vectorized::VScanNode::_normalize_noneq_binary_predicate<(doris::PrimitiveType)5>(doris::vectorized::VExpr*, doris::vectorized::VExprContext*, doris::SlotDescriptor*, doris::ColumnValueRange<(doris::PrimitiveType)5>&, doris::vectorized::VScanNode::PushDownType*) at /mnt/disk2/tengjianping/doris-39/be/src/vec/exec/scan/vscan_node.cpp:995
12# auto doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1::operator()<doris::ColumnValueRange<(doris::PrimitiveType)5> >(doris::ColumnValueRange<(doris::PrimitiveType)5>&) const at /mnt/disk2/tengjianping/doris-39/be/src/vec/exec/scan/vscan_node.cpp:515
13# void std::__invoke_impl<void, doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1, doris::ColumnValueRange<(doris::PrimitiveType)5>&>(std::__invoke_other, doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1&&, doris::ColumnValueRange<(doris::PrimitiveType)5>&) at /mnt/disk2/tengjianping/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61
14# std::__invoke_result<doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1, doris::ColumnValueRange<(doris::PrimitiveType)5>&>::type std::__invoke<doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1, doris::ColumnValueRange<(doris::PrimitiveType)5>&>(doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1&&, doris::ColumnValueRange<(doris::PrimitiveType)5>&) at /mnt/disk2/tengjianping/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96
15# std::__detail::__variant::__gen_vtable_impl<std::__detail::__variant::_Multi_array<std::__detail::__variant::__deduce_visit_result<void> (*)(doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1&&, std::variant<doris::ColumnValueRange<(doris::PrimitiveType)3>, doris::ColumnValueRange<(doris::PrimitiveType)4>, doris::ColumnValueRange<(doris::PrimitiveType)5>, doris::ColumnValueRange<(doris::PrimitiveType)6>, doris::ColumnValueRange<(doris::PrimitiveType)7>, doris::ColumnValueRange<(doris::PrimitiveType)15>, doris::ColumnValueRange<(doris::PrimitiveType)10>, doris::ColumnValueRange<(doris::PrimitiveType)23>, doris::ColumnValueRange<(doris::PrimitiveType)11>, doris::ColumnValueRange<(doris::PrimitiveType)25>, doris::ColumnValueRange<(doris::PrimitiveType)12>, doris::ColumnValueRange<(doris::PrimitiveType)26>, doris::ColumnValueRange<(doris::PrimitiveType)20>, doris::ColumnValueRange<(doris::PrimitiveType)2>, doris::ColumnValueRange<(doris::PrimitiveType)19>, doris::ColumnValueRange<(doris::PrimitiveType)28>, doris::ColumnValueRange<(doris::PrimitiveType)29>, doris::ColumnValueRange<(doris::PrimitiveType)30>, doris::ColumnValueRange<(doris::PrimitiveType)35> >&)>, std::integer_sequence<unsigned long, 2ul> >::__visit_invoke(doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1&&, std::variant<doris::ColumnValueRange<(doris::PrimitiveType)3>, doris::ColumnValueRange<(doris::PrimitiveType)4>, doris::ColumnValueRange<(doris::PrimitiveType)5>, doris::ColumnValueRange<(doris::PrimitiveType)6>, doris::ColumnValueRange<(doris::PrimitiveType)7>, doris::ColumnValueRange<(doris::PrimitiveType)15>, doris::ColumnValueRange<(doris::PrimitiveType)10>, doris::ColumnValueRange<(doris::PrimitiveType)23>, doris::ColumnValueRange<(doris::PrimitiveType)11>, doris::ColumnValueRange<(doris::PrimitiveType)25>, doris::ColumnValueRange<(doris::PrimitiveType)12>, doris::ColumnValueRange<(doris::PrimitiveType)26>, doris::ColumnValueRange<(doris::PrimitiveType)20>, doris::ColumnValueRange<(doris::PrimitiveType)2>, doris::ColumnValueRange<(doris::PrimitiveType)19>, doris::ColumnValueRange<(doris::PrimitiveType)28>, doris::ColumnValueRange<(doris::PrimitiveType)29>, doris::ColumnValueRange<(doris::PrimitiveType)30>, doris::ColumnValueRange<(doris::PrimitiveType)35> >&) at /mnt/disk2/tengjianping/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/variant:1013
16# decltype(auto) std::__do_visit<std::__detail::__variant::__deduce_visit_result<void>, doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1, std::variant<doris::ColumnValueRange<(doris::PrimitiveType)3>, doris::ColumnValueRange<(doris::PrimitiveType)4>, doris::ColumnValueRange<(doris::PrimitiveType)5>, doris::ColumnValueRange<(doris::PrimitiveType)6>, doris::ColumnValueRange<(doris::PrimitiveType)7>, doris::ColumnValueRange<(doris::PrimitiveType)15>, doris::ColumnValueRange<(doris::PrimitiveType)10>, doris::ColumnValueRange<(doris::PrimitiveType)23>, doris::ColumnValueRange<(doris::PrimitiveType)11>, doris::ColumnValueRange<(doris::PrimitiveType)25>, doris::ColumnValueRange<(doris::PrimitiveType)12>, doris::ColumnValueRange<(doris::PrimitiveType)26>, doris::ColumnValueRange<(doris::PrimitiveType)20>, doris::ColumnValueRange<(doris::PrimitiveType)2>, doris::ColumnValueRange<(doris::PrimitiveType)19>, doris::ColumnValueRange<(doris::PrimitiveType)28>, doris::ColumnValueRange<(doris::PrimitiveType)29>, doris::ColumnValueRange<(doris::PrimitiveType)30>, doris::ColumnValueRange<(doris::PrimitiveType)35> >&>(doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1&&, std::variant<doris::ColumnValueRange<(doris::PrimitiveType)3>, doris::ColumnValueRange<(doris::PrimitiveType)4>, doris::ColumnValueRange<(doris::PrimitiveType)5>, doris::ColumnValueRange<(doris::PrimitiveType)6>, doris::ColumnValueRange<(doris::PrimitiveType)7>, doris::ColumnValueRange<(doris::PrimitiveType)15>, doris::ColumnValueRange<(doris::PrimitiveType)10>, doris::ColumnValueRange<(doris::PrimitiveType)23>, doris::ColumnValueRange<(doris::PrimitiveType)11>, doris::ColumnValueRange<(doris::PrimitiveType)25>, doris::ColumnValueRange<(doris::PrimitiveType)12>, doris::ColumnValueRange<(doris::PrimitiveType)26>, doris::ColumnValueRange<(doris::PrimitiveType)20>, doris::ColumnValueRange<(doris::PrimitiveType)2>, doris::ColumnValueRange<(doris::PrimitiveType)19>, doris::ColumnValueRange<(doris::PrimitiveType)28>, doris::ColumnValueRange<(doris::PrimitiveType)29>, doris::ColumnValueRange<(doris::PrimitiveType)30>, doris::ColumnValueRange<(doris::PrimitiveType)35> >&) at /mnt/disk2/tengjianping/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/variant:1716
17# decltype(auto) std::visit<doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1, std::variant<doris::ColumnValueRange<(doris::PrimitiveType)3>, doris::ColumnValueRange<(doris::PrimitiveType)4>, doris::ColumnValueRange<(doris::PrimitiveType)5>, doris::ColumnValueRange<(doris::PrimitiveType)6>, doris::ColumnValueRange<(doris::PrimitiveType)7>, doris::ColumnValueRange<(doris::PrimitiveType)15>, doris::ColumnValueRange<(doris::PrimitiveType)10>, doris::ColumnValueRange<(doris::PrimitiveType)23>, doris::ColumnValueRange<(doris::PrimitiveType)11>, doris::ColumnValueRange<(doris::PrimitiveType)25>, doris::ColumnValueRange<(doris::PrimitiveType)12>, doris::ColumnValueRange<(doris::PrimitiveType)26>, doris::ColumnValueRange<(doris::PrimitiveType)20>, doris::ColumnValueRange<(doris::PrimitiveType)2>, doris::ColumnValueRange<(doris::PrimitiveType)19>, doris::ColumnValueRange<(doris::PrimitiveType)28>, doris::ColumnValueRange<(doris::PrimitiveType)29>, doris::ColumnValueRange<(doris::PrimitiveType)30>, doris::ColumnValueRange<(doris::PrimitiveType)35> >&>(doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&)::$_1&&, std::variant<doris::ColumnValueRange<(doris::PrimitiveType)3>, doris::ColumnValueRange<(doris::PrimitiveType)4>, doris::ColumnValueRange<(doris::PrimitiveType)5>, doris::ColumnValueRange<(doris::PrimitiveType)6>, doris::ColumnValueRange<(doris::PrimitiveType)7>, doris::ColumnValueRange<(doris::PrimitiveType)15>, doris::ColumnValueRange<(doris::PrimitiveType)10>, doris::ColumnValueRange<(doris::PrimitiveType)23>, doris::ColumnValueRange<(doris::PrimitiveType)11>, doris::ColumnValueRange<(doris::PrimitiveType)25>, doris::ColumnValueRange<(doris::PrimitiveType)12>, doris::ColumnValueRange<(doris::PrimitiveType)26>, doris::ColumnValueRange<(doris::PrimitiveType)20>, doris::ColumnValueRange<(doris::PrimitiveType)2>, doris::ColumnValueRange<(doris::PrimitiveType)19>, doris::ColumnValueRange<(doris::PrimitiveType)28>, doris::ColumnValueRange<(doris::PrimitiveType)29>, doris::ColumnValueRange<(doris::PrimitiveType)30>, doris::ColumnValueRange<(doris::PrimitiveType)35> >&) at /mnt/disk2/tengjianping/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/variant:1772
18# doris::vectorized::VScanNode::_normalize_predicate(std::shared_ptr<doris::vectorized::VExpr> const&, doris::vectorized::VExprContext*, std::shared_ptr<doris::vectorized::VExpr>&) at /mnt/disk2/tengjianping/doris-39/be/src/vec/exec/scan/vscan_node.cpp:500
19# doris::vectorized::VScanNode::_normalize_conjuncts() at /mnt/disk2/tengjianping/doris-39/be/src/vec/exec/scan/vscan_node.cpp:418
20# doris::vectorized::VScanNode::_process_conjuncts() at /mnt/disk2/tengjianping/doris-39/be/src/vec/exec/scan/vscan_node.h:195
21# doris::vectorized::NewOlapScanNode::_process_conjuncts() at /mnt/disk2/tengjianping/doris-39/be/src/vec/exec/scan/new_olap_scan_node.cpp:248
22# doris::vectorized::VScanNode::alloc_resource(doris::RuntimeState*) at /mnt/disk2/tengjianping/doris-39/be/src/vec/exec/scan/vscan_node.cpp:184
23# doris::pipeline::StreamingOperator<doris::pipeline::ScanOperatorBuilder>::open(doris::RuntimeState*) at /mnt/disk2/tengjianping/doris-39/be/src/pipeline/exec/operator.h:360
24# doris::pipeline::PipelineTask::_open() at /mnt/disk2/tengjianping/doris-39/be/src/pipeline/pipeline_task.cpp:205
25# doris::pipeline::PipelineTask::execute(bool*) at /mnt/disk2/tengjianping/doris-39/be/src/pipeline/pipeline_task.cpp:235
26# doris::pipeline::TaskScheduler::_do_work(unsigned long) at /mnt/disk2/tengjianping/doris-39/be/src/pipeline/task_scheduler.cpp:281

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

jacktengg · 2023-11-21T06:40:42Z

run buildall

github-actions · 2023-11-21T06:45:42Z

clang-tidy review says "All clean, LGTM! 👍"

xinyiZzz

LGTM

github-actions · 2023-11-21T06:48:21Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-11-21T06:48:24Z

PR approved by anyone and no changes requested.

doris-robot · 2023-11-21T07:19:09Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 954e921cdc171e6104d693224a2ea06fa897768b, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4878	4687	4700	4687
q2	373	160	160	160
q3	2022	2004	1886	1886
q4	1387	1258	1256	1256
q5	3976	3929	4011	3929
q6	248	127	125	125
q7	1408	885	902	885
q8	2739	2776	2753	2753
q9	12472	12907	9607	9607
q10	10261	3557	3538	3538
q11	407	246	243	243
q12	446	292	298	292
q13	4564	3834	3814	3814
q14	318	287	292	287
q15	574	526	515	515
q16	676	581	587	581
q17	1141	960	919	919
q18	7689	7295	7470	7295
q19	1752	1679	1656	1656
q20	548	314	291	291
q21	4385	3940	3899	3899
q22	467	366	380	366
Total cold run time: 62731 ms
Total hot run time: 48984 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4601	4574	4572	4572
q2	332	223	253	223
q3	4001	3987	3984	3984
q4	2687	2682	2683	2682
q5	9634	9627	9651	9627
q6	244	124	123	123
q7	3010	2463	2481	2463
q8	4404	4429	4416	4416
q9	13112	13133	13142	13133
q10	4095	4186	4194	4186
q11	755	685	638	638
q12	988	805	826	805
q13	4228	3572	3523	3523
q14	378	359	329	329
q15	576	527	528	527
q16	745	659	678	659
q17	3854	3892	3930	3892
q18	9584	9046	9053	9046
q19	1791	1764	1761	1761
q20	2364	2106	2030	2030
q21	8686	8458	8632	8458
q22	943	834	817	817
Total cold run time: 81012 ms
Total hot run time: 77894 ms

doris-robot · 2023-11-21T07:22:07Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.72 seconds
stream load tsv: 572 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17097919630 Bytes

yiguolei

LGTM

doris-robot · 2023-11-21T07:34:24Z

TeamCity be ut coverage result:
Function Coverage: 36.53% (8448/23125)
Line Coverage: 28.86% (68673/237939)
Region Coverage: 27.82% (35511/127640)
Branch Coverage: 24.58% (18114/73684)
Coverage Report: http://coverage.selectdb-in.cc/coverage/954e921cdc171e6104d693224a2ea06fa897768b_954e921cdc171e6104d693224a2ea06fa897768b/report/index.html

jacktengg · 2023-11-21T08:21:06Z

run buildall

github-actions · 2023-11-21T08:26:57Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-11-21T08:27:53Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-11-21T08:44:49Z

TeamCity be ut coverage result:
Function Coverage: 36.53% (8448/23125)
Line Coverage: 28.87% (68682/237939)
Region Coverage: 27.83% (35525/127642)
Branch Coverage: 24.58% (18113/73686)
Coverage Report: http://coverage.selectdb-in.cc/coverage/85d095044812586c4183fdc0ef659b2c40557377_85d095044812586c4183fdc0ef659b2c40557377/report/index.html

doris-robot · 2023-11-21T08:56:10Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 52 seconds
stream load tsv: 585 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17098961434 Bytes

doris-robot · 2023-11-21T09:19:44Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 85d095044812586c4183fdc0ef659b2c40557377, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4916	4680	4638	4638
q2	390	180	165	165
q3	2060	1889	1902	1889
q4	1373	1255	1236	1236
q5	3963	3950	3988	3950
q6	246	130	130	130
q7	1437	891	882	882
q8	2726	2773	2755	2755
q9	23896	12883	9573	9573
q10	10273	3527	3533	3527
q11	399	247	246	246
q12	463	302	290	290
q13	4578	3842	3793	3793
q14	328	289	288	288
q15	592	534	519	519
q16	688	587	583	583
q17	1142	944	908	908
q18	7809	7273	7425	7273
q19	1692	1678	1677	1677
q20	558	313	309	309
q21	4416	3963	3961	3961
q22	480	376	381	376
Total cold run time: 74425 ms
Total hot run time: 48968 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4608	4569	4564	4564
q2	342	236	262	236
q3	4002	3981	3984	3981
q4	2703	2692	2712	2692
q5	9741	9643	9702	9643
q6	244	124	124	124
q7	3017	2480	2467	2467
q8	4436	4445	4420	4420
q9	13249	13129	13209	13129
q10	4123	4208	4193	4193
q11	805	636	734	636
q12	977	836	817	817
q13	4303	3608	3593	3593
q14	390	348	345	345
q15	574	530	515	515
q16	727	673	682	673
q17	3884	3926	3888	3888
q18	9567	9168	9186	9168
q19	1803	1765	1786	1765
q20	2383	2060	2057	2057
q21	8804	8686	8617	8617
q22	902	785	777	777
Total cold run time: 81584 ms
Total hot run time: 78300 ms

jacktengg · 2023-11-21T09:39:42Z

run p0

HappenLee

LGTM

wangbo

LGTM

xinyiZzz previously approved these changes Nov 21, 2023

View reviewed changes

github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2023

github-actions Bot added the reviewed label Nov 21, 2023

yiguolei previously approved these changes Nov 21, 2023

View reviewed changes

jacktengg dismissed stale reviews from yiguolei and xinyiZzz via 5d1ba4f November 21, 2023 08:20

jacktengg added 2 commits November 21, 2023 16:20

[fix](null equal) fix coredump of pushing eq_for_null

ac974d6

fix

85d0950

jacktengg force-pushed the fix-null-eq-core2 branch from 5d1ba4f to 85d0950 Compare November 21, 2023 08:20

xiaokang added the dev/2.0.4 label Nov 21, 2023

HappenLee approved these changes Nov 21, 2023

View reviewed changes

wangbo approved these changes Nov 21, 2023

View reviewed changes

yiguolei merged commit 1ebb54a into apache:master Nov 21, 2023

seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 28, 2023

[fix](null equal) fix coredump of pushing eq_for_null (apache#27341)

2631a1b

wm1581066 added the p0_c label Dec 11, 2023

yiguolei removed the dev/2.0.4 label Dec 13, 2023

yiguolei added the dev/2.0.4 label Dec 13, 2023

XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023

[fix](null equal) fix coredump of pushing eq_for_null (apache#27341)

7518d6c

jacktengg mentioned this pull request Dec 15, 2023

[fix](null equal) fix coredump of pushing eq_for_null (#27341) #28495

Merged

yiguolei added dev/2.0.4-merged and removed dev/2.0.4 labels Dec 15, 2023

Uh oh!

Conversation

jacktengg commented Nov 21, 2023

Proposed changes

Further comments

Uh oh!

jacktengg commented Nov 21, 2023

Uh oh!

github-actions Bot commented Nov 21, 2023

Uh oh!

xinyiZzz left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 21, 2023

Uh oh!

github-actions Bot commented Nov 21, 2023

Uh oh!

doris-robot commented Nov 21, 2023

Uh oh!

doris-robot commented Nov 21, 2023

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Nov 21, 2023

Uh oh!

jacktengg commented Nov 21, 2023

Uh oh!

github-actions Bot commented Nov 21, 2023

Uh oh!

github-actions Bot commented Nov 21, 2023

Uh oh!

doris-robot commented Nov 21, 2023

Uh oh!

doris-robot commented Nov 21, 2023

Uh oh!

doris-robot commented Nov 21, 2023

Uh oh!

jacktengg commented Nov 21, 2023

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

wangbo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants