Thanks to visit codestin.com
Credit goes to github.com

Skip to content

branch-3.0: [improve](planner) select * unique_table limit n should use one instance #53948#54182

Merged
dataroaring merged 1 commit into
branch-3.0from
auto-pick-53948-branch-3.0
Aug 13, 2025
Merged

branch-3.0: [improve](planner) select * unique_table limit n should use one instance #53948#54182
dataroaring merged 1 commit into
branch-3.0from
auto-pick-53948-branch-3.0

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked from #53948

@zhangstar333
[improve](planner) select * unique_table limit n should use one insta…
646c20a 
…nce (#53948)

### What problem does this PR solve?
Problem Summary:
the unique_table has a condition of delete_sign = 0 awalys,
so it's not have plan for one instance to scan table,
now add some check for unique_table let running only one instance for
select limit n.
@github-actions github-actions Bot requested a review from dataroaring as a code owner August 1, 2025 06:15
@Thearas

Thearas commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Aug 1, 2025
@dataroaring dataroaring reopened this Aug 1, 2025
@Thearas

Thearas commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Aug 1, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 39533 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 646c20a9e59a98463e2915787d36f1b41681dadf, data reload: false

------ Round 1 ----------------------------------
q1	17583	6879	6600	6600
q2	2088	195	154	154
q3	10650	1118	1186	1118
q4	10452	722	688	688
q5	7721	2907	2769	2769
q6	218	132	128	128
q7	945	617	588	588
q8	9395	1925	2070	1925
q9	6676	6446	6449	6446
q10	7086	2264	2309	2264
q11	465	273	256	256
q12	413	221	213	213
q13	17810	2951	2967	2951
q14	231	200	203	200
q15	513	474	451	451
q16	478	372	374	372
q17	984	629	568	568
q18	7205	6759	6533	6533
q19	1401	1070	1036	1036
q20	481	191	201	191
q21	3976	3082	3077	3077
q22	1098	1010	1005	1005
Total cold run time: 107869 ms
Total hot run time: 39533 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6672	6556	6509	6509
q2	323	228	228	228
q3	2849	2929	2894	2894
q4	2009	1777	1914	1777
q5	5669	5682	5703	5682
q6	212	127	128	127
q7	2233	1787	1823	1787
q8	3335	3529	3517	3517
q9	8774	8846	8839	8839
q10	3565	3508	3484	3484
q11	592	491	499	491
q12	799	594	585	585
q13	7148	3160	3107	3107
q14	297	275	265	265
q15	524	464	458	458
q16	488	444	443	443
q17	1835	1644	1611	1611
q18	8318	7688	7781	7688
q19	1687	1626	1504	1504
q20	2052	1813	1801	1801
q21	5199	4911	5011	4911
q22	1211	1042	1019	1019
Total cold run time: 65791 ms
Total hot run time: 58727 ms

@hello-stephen

hello-stephen commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.90% (11137/26581)
Line Coverage 32.42% (95385/294214)
Region Coverage 31.57% (49282/156123)
Branch Coverage 28.01% (25264/90192)

@doris-robot

doris-robot commented Aug 1, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 196213 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 646c20a9e59a98463e2915787d36f1b41681dadf, data reload: false

query1	1303	933	886	886
query2	6394	1892	1858	1858
query3	10889	4673	4526	4526
query4	33221	23199	23365	23199
query5	3488	477	458	458
query6	270	166	169	166
query7	3986	310	317	310
query8	296	227	226	226
query9	9379	2577	2567	2567
query10	473	261	250	250
query11	17841	15237	15230	15230
query12	159	102	102	102
query13	1549	421	415	415
query14	9340	7509	6876	6876
query15	251	183	199	183
query16	8035	492	517	492
query17	1633	606	594	594
query18	2148	328	320	320
query19	225	180	173	173
query20	123	120	118	118
query21	205	107	114	107
query22	4643	4406	4675	4406
query23	34844	34136	34298	34136
query24	11488	2942	2897	2897
query25	673	418	425	418
query26	837	169	172	169
query27	2209	354	357	354
query28	6961	2159	2108	2108
query29	813	472	449	449
query30	263	169	163	163
query31	1036	828	845	828
query32	104	58	56	56
query33	808	298	288	288
query34	959	517	498	498
query35	877	735	753	735
query36	1123	935	960	935
query37	130	66	67	66
query38	4076	4087	3963	3963
query39	1565	1495	1463	1463
query40	197	105	98	98
query41	48	51	47	47
query42	117	99	101	99
query43	527	488	483	483
query44	1256	808	799	799
query45	185	172	175	172
query46	1158	710	721	710
query47	2006	1903	1921	1903
query48	474	382	389	382
query49	948	381	379	379
query50	865	433	446	433
query51	7443	7266	7337	7266
query52	105	90	92	90
query53	261	185	184	184
query54	1251	468	465	465
query55	79	79	79	79
query56	261	240	237	237
query57	1314	1223	1178	1178
query58	230	213	206	206
query59	3211	2961	3096	2961
query60	289	259	247	247
query61	113	104	112	104
query62	896	727	712	712
query63	221	191	189	189
query64	4019	652	636	636
query65	3368	3285	3298	3285
query66	1462	300	293	293
query67	16160	15563	15454	15454
query68	4421	572	573	572
query69	418	268	257	257
query70	1189	1164	1120	1120
query71	352	260	250	250
query72	6314	4028	3934	3934
query73	755	352	349	349
query74	10477	9047	8919	8919
query75	3382	2615	2656	2615
query76	2805	1053	961	961
query77	381	280	265	265
query78	10596	9610	9617	9610
query79	2445	609	594	594
query80	1073	429	424	424
query81	552	223	226	223
query82	824	86	89	86
query83	234	146	145	145
query84	239	78	75	75
query85	1477	304	289	289
query86	487	297	302	297
query87	4379	4239	4241	4239
query88	4511	2361	2341	2341
query89	414	293	284	284
query90	1929	184	185	184
query91	180	146	145	145
query92	61	46	49	46
query93	2375	549	540	540
query94	757	271	300	271
query95	353	255	249	249
query96	624	278	285	278
query97	3340	3090	3189	3090
query98	209	195	199	195
query99	1519	1287	1309	1287
Total cold run time: 302153 ms
Total hot run time: 196213 ms

@doris-robot

doris-robot commented Aug 1, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.83 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 646c20a9e59a98463e2915787d36f1b41681dadf, data reload: false

query1	0.04	0.04	0.02
query2	0.07	0.04	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.50	0.50	0.50
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.57	0.50	0.51
query10	0.55	0.57	0.59
query11	0.16	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.58
query14	0.76	0.80	0.79
query15	0.84	0.84	0.82
query16	0.36	0.39	0.38
query17	1.02	0.97	1.07
query18	0.23	0.21	0.21
query19	1.93	1.87	1.73
query20	0.02	0.01	0.01
query21	15.40	0.57	0.58
query22	2.51	1.55	1.88
query23	17.07	0.98	0.88
query24	3.31	1.13	0.95
query25	0.23	0.06	0.04
query26	0.50	0.14	0.14
query27	0.04	0.04	0.04
query28	10.09	0.48	0.48
query29	12.62	3.26	3.22
query30	0.26	0.07	0.06
query31	2.82	0.37	0.38
query32	3.30	0.46	0.46
query33	2.98	2.99	3.03
query34	17.03	4.53	4.52
query35	4.58	4.56	4.56
query36	0.65	0.49	0.47
query37	0.09	0.07	0.06
query38	0.06	0.03	0.03
query39	0.04	0.02	0.03
query40	0.16	0.12	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.01
query43	0.04	0.03	0.02
Total cold run time: 104.74 s
Total hot run time: 29.83 s

dataroaring
dataroaring approved these changes Aug 12, 2025
View reviewed changes

@dataroaring dataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 12, 2025
@github-actions

github-actions Bot commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 48c8fc7 into branch-3.0 Aug 13, 2025
23 of 25 checks passed
@github-actions github-actions Bot deleted the auto-pick-53948-branch-3.0 branch August 13, 2025 01:50
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @hello-stephen @dataroaring @zhangstar333