Fix #13799: Add unit test for YamlCodec to verify security #15958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
d382534 to
8bfa3e9
Compare
Contributor
|
file mode should not be modified. |
Contributor
Author
|
Hi @zrlw, sorry about the file mode issue. I am opening a new clean PR with core.fileMode set to false to ensure permissions remain unchanged. Thank you for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
This PR adds a unit test for YamlCodec to ensure it properly rejects malicious YAML payloads, preventing potential RCE vulnerabilities (CVE-2022-1471).
Brief changelog
Verifying this change