Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement tags filtering logic in TagStateRouter and add unit test for tag routing #16021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RainYuY wants to merge 2 commits into
base: 3.3
Choose a base branch
from
Open

Implement tags filtering logic in TagStateRouter and add unit test for tag routing #16021

RainYuY wants to merge 2 commits into from
+61 −7

Conversation

@RainYuY
Copy link
Member

@RainYuY RainYuY commented Jan 19, 2026

What is the purpose of the change?

#4912

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@RainYuY RainYuY added the type/discussion Everything related with code discussion or question label Jan 19, 2026
@RainYuY
Copy link
Member Author

RainYuY commented Jan 19, 2026

This is designed for a specific scenario: a provider can accept requests from consumers with tag a and tag b (where tags may represent regions), but cannot accept requests from consumers with tag c. In such cases, users can configure the provider to support both tag a and tag b simultaneously to achieve this requirement.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.76%. Comparing base (a92d5d0) to head (b9506da).

Files with missing lines Patch % Lines
...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                3.3   #16021   +/-   ##
=========================================
  Coverage     60.75%   60.76%           
  Complexity    11736    11736           
=========================================
  Files          1949     1949           
  Lines         88801    88809    +8     
  Branches      13391    13395    +4     
=========================================
+ Hits          53952    53964   +12     
+ Misses        29314    29307    -7     
- Partials       5535     5538    +3
Flag Coverage Δ
integration-tests-java21 32.21% <0.00%> (-0.01%) ⬇️
integration-tests-java8 32.29% <0.00%> (-0.07%) ⬇️
samples-tests-java21 32.14% <33.33%> (+0.02%) ⬆️
samples-tests-java8 29.82% <33.33%> (+0.10%) ⬆️
unit-tests-java11 59.01% <83.33%> (-0.03%) ⬇️
unit-tests-java17 58.52% <83.33%> (+<0.01%) ⬆️
unit-tests-java21 58.52% <83.33%> (+<0.01%) ⬆️
unit-tests-java25 58.48% <83.33%> (-0.01%) ⬇️
unit-tests-java8 59.04% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw
Copy link
Contributor

zrlw commented Jan 24, 2026 •
edited
Loading

tags.support might be superfluous‌. e.g., multiple groups function has been supported by setting multiple groups with seperator comma directly in the attribute group of @DubboReference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ Awaiting requested review from AlbumenJ

@chickenlj chickenlj Awaiting requested review from chickenlj

@CrazyHZM CrazyHZM Awaiting requested review from CrazyHZM

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

type/discussion Everything related with code discussion or question

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RainYuY @codecov-commenter @zrlw