Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix adaptive metrics decay when provider metrics are not updated #16048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SURYAS1306 wants to merge 3 commits into
base: 3.3
Choose a base branch
from
Open

Fix adaptive metrics decay when provider metrics are not updated #16048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8946d40
Fix adaptive metrics decay when provider metrics are not updated
Jan 25, 2026
ddaa5f2
Add high-QPS style test for adaptive metrics decay
Jan 27, 2026
2113910
Merge branch '3.3' into fix-adaptive-metrics-decay
zrlw Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 90 additions & 0 deletions ...uster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/AdaptiveLoadBalanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import org.apache.dubbo.rpc.Invoker;
import org.apache.dubbo.rpc.model.ApplicationModel;

import java.lang.reflect.Field;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.atomic.AtomicInteger;
Expand Down Expand Up @@ -165,4 +166,93 @@ void testSelectByAdaptive() {
Math.abs(sumInvoker5 / (weightMap.get(weightInvoker5) * ewma5) - expectWeightValue) < maxDeviation,
"select failed!");
}

@Test
@Order(2)
void testAdaptiveMetricsDecayWithoutProviderUpdate() throws Exception {
AdaptiveMetrics metrics = new AdaptiveMetrics();

String id = "test";
int timeout = 100;

Map<String, String> map = new HashMap<>();
map.put("curTime", String.valueOf(System.currentTimeMillis()));
map.put("rt", "200");
map.put("load", "0.5");

metrics.setProviderMetrics(id, map);

AdaptiveMetrics status = metrics.getStatus(id);

long past = System.currentTimeMillis() - 500;
setLongField(status, "currentTime", past);
setLongField(status, "currentProviderTime", past);

long before = getLongField(status, "lastLatency");

metrics.getLoad(id, 100, timeout);

Thread.sleep(150);

metrics.getLoad(id, 100, timeout);

long after = getLongField(status, "lastLatency");

Assertions.assertTrue(after > 0);
Assertions.assertNotEquals(timeout * 2L, after);
Assertions.assertNotEquals(before, after);
}

private long getLongField(Object obj, String name) throws Exception {
Field field = obj.getClass().getDeclaredField(name);
field.setAccessible(true);
return (long) field.get(obj);
}

private void setLongField(Object obj, String name, long value) throws Exception {
Field field = obj.getClass().getDeclaredField(name);
field.setAccessible(true);
field.set(obj, value);
}

@Test
@Order(3)
void testAdaptiveMetricsDecayHighQps() throws Exception {
AdaptiveMetrics metrics = new AdaptiveMetrics();

String id = "highQpsTest";
int timeout = 100;

Map<String, String> map = new HashMap<>();
map.put("curTime", String.valueOf(System.currentTimeMillis()));
map.put("rt", "300");
map.put("load", "1");

metrics.setProviderMetrics(id, map);

AdaptiveMetrics status = metrics.getStatus(id);

long past = System.currentTimeMillis() - 1000;
setLongField(status, "currentTime", past);
setLongField(status, "currentProviderTime", past);

long before = getLongField(status, "lastLatency");

// simulate high QPS: many rapid getLoad calls without provider updates
for (int i = 0; i < 1000; i++) {
metrics.getLoad(id, 100, timeout);
}

Thread.sleep(120);

for (int i = 0; i < 1000; i++) {
metrics.getLoad(id, 100, timeout);
}

long after = getLongField(status, "lastLatency");

Assertions.assertTrue(after > 0);
Assertions.assertNotEquals(before, after);
Assertions.assertNotEquals(timeout * 2L, after);
}
}
4 changes: 2 additions & 2 deletions dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/AdaptiveMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ public double getLoad(String idKey, int weight, int timeout) {
if (metrics.currentTime > 0) {
long multiple = (System.currentTimeMillis() - metrics.currentTime) / timeout + 1;
if (multiple > 0) {
if (metrics.currentProviderTime == metrics.currentTime) {
if (metrics.currentProviderTime > metrics.currentTime) {
// penalty value
metrics.lastLatency = timeout * 2L;
} else {
metrics.lastLatency = metrics.lastLatency >> multiple;
metrics.lastLatency = Math.max(1L, metrics.lastLatency >> multiple);
}
metrics.ewma = metrics.beta * metrics.ewma + (1 - metrics.beta) * metrics.lastLatency;
metrics.currentTime = System.currentTimeMillis();
Expand Down
Loading