-
Notifications
You must be signed in to change notification settings - Fork 19.8k
feat(tooltip): add appendTo option to allow customizing tooltip container
#18436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c4efc1f
feat: allow customed tooltip container
e188b20
refactor: rename variables: getAppendElement => teleport & customCont…
92bcf21
feat: support 3 options to locale the tooltip container
723e13b
refactor: rename customContainer to container
a1b9d0f
fix: add model params name
19f68c5
refactor: rename variables: getAppendElement => teleport & customCont…
77e48e4
refactor: update based on cr
d038881
fix: add missing variable
eb8793f
test: add test case for appendTo
efb00a7
fix: add fallback
aeff150
fix: only update styled to position:relative when there is no custom …
6ecd62b
refactor: rename element name
368d0a8
fix: clearing the _container & el in the dispose function
7df2718
fix: chartContainer always exists
757877e
test: tweak test case
plainheart 8d7aa91
Merge branch 'master' of https://github.com/apache/echarts into toolt…
plainheart de730f9
chore: tweak comment
plainheart fd4ef78
fix(tooltip): fix potential exception when `appendTo` is an empty string
plainheart 2864cd1
fix(tooltip): fix potential exception when `appendTo` is an empty str…
plainheart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.