Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(label): fix labelLine smooth can not be reset#21425

Merged
plainheart merged 5 commits into
apache:masterfrom
fanwww:fix-pie-labelLine-smooth
Dec 15, 2025
Merged

fix(label): fix labelLine smooth can not be reset#21425
plainheart merged 5 commits into
apache:masterfrom
fanwww:fix-pie-labelLine-smooth

Conversation

@fanwww
Copy link
Copy Markdown
Contributor

@fanwww fanwww commented Dec 15, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixes the issue where changing labelLine.smooth from true to false does not take effect in pie charts.

Fixed issues

Details

Before: What was the problem?

There was an issue with the labelLine.smooth configuration in pie charts (Issue #21418). When smooth was initially set to true and then changed to false dynamically (through setOption or in initial configuration), the label lines remained as smooth curves instead of reverting to straight lines. This prevented users from properly controlling the visual style of label lines.

Reproduction steps:

  1. Set labelLine.smooth: true in pie chart configuration
  2. Update configuration with labelLine.smooth: false
  3. Observe that label lines still appear as smooth curves

After: How does it behave after the fixing?

After the fix, the labelLine.smooth configuration now correctly responds to changes. When smooth is changed from true to false, the label lines immediately update to straight lines as expected. This ensures proper dynamic control over label line styling.

Verification:

  • Setting labelLine.smooth: false now correctly renders straight label lines
  • Dynamic updates between true and false values work correctly
  • Backward compatibility is maintained for existing configurations

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

Security Checking

  • This PR uses security-sensitive Web APIs.

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Dec 15, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.

Comment thread src/label/labelGuideHelper.ts Outdated
@plainheart plainheart added this to the 6.0.1 milestone Dec 15, 2025
@plainheart plainheart changed the title Fix pie label line smooth fix(label): fix labelLine smooth can not be reset Dec 15, 2025
fanwww and others added 3 commits December 15, 2025 20:16
@plainheart plainheart merged commit c237496 into apache:master Dec 15, 2025
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Dec 15, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Changing the smooth attribute from true to false in the pie chart labelLine configuration item does not take effect

2 participants