fix(custom): restore emphasis for large datasets (#21442)#21463
Open
dilipkumar6306316-art wants to merge 2 commits intoapache:masterfrom
Open
fix(custom): restore emphasis for large datasets (#21442)#21463dilipkumar6306316-art wants to merge 2 commits intoapache:masterfrom
dilipkumar6306316-art wants to merge 2 commits intoapache:masterfrom
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21463@292748e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Custom series elements with large datasets (~3000+ points) were being marked as
silent/ignoreby ECharts for performance reasons. As a result, hover and emphasis (highlighting) did not work
even when
emphasiswas explicitly defined inrenderItem. This is tracked in issue #21442.Solution
This PR ensures that any custom element with an
emphasisstate is not marked as silent or ignored.The fix is applied in
src/chart/custom/CustomView.tsjust beforetoggleHoverEmphasisis called.emphasisare affectedemphasisDisabledis respectedHow to Test
http://localhost:9001)dataCountto ~3000-4000Related Issue
Closes #21442