FINERACT-1724 - Fix testcases failing on the end of the month due to missing timezone configuration #3357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cc510a to
67e8e37
Compare
galovics
approved these changes
Aug 4, 2023
- setting the timezone for the unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testcases may fail at the end of the month. It is happening because of the testcase’s TZ is might not be in align with the servers timezone.
It is explained below using the testFixedDepositAccountWithPrematureClosureTypeWithdrawal_WITH_HOLD_TAX teastcase
Scenario #1, Tesctase running in UTC, time is 2023.08.31, 08:00 PM, Server is in Asia/Kolkata, so there the time is 2023.09.01 01:30 AM (UTC +5.5)
Fixed Deposit Account will be created with ACTIVATION_DATE = 2023.07.31, (Client time - 1 month)
Then client will trigger the posting of the interest
Server will calculate the interests, there is on 2023-08-01 and another on 2023-09-01
Testcase only expects a single interest in the expense ledger account, but we have two, so it will FAIL.
Scenario #2, Tesctase running in Asia/Kolkata, time is 2023.08.31, 08:00 PM, Server is in Asia/Kolkata, so there the time is 2023.08.31 08:00 PM
Fixed Deposit Account will be created with ACTIVATION_DATE = 2023.07.31, (Client time - 1 month)
Then client will trigger the posting of the interest
Server will calculate a single interest, there is on 2023-08-01
Testcase only expects a single interest and the amount is matching. PASS
Scenario #3, Tesctase running in UTC, time is 2023.09.01 02:00 AM, Server is in Asia/Kolkata, so there the time is 2023.09.01 07:30 AM (UTC +5.5)
Fixed Deposit Account will be created with ACTIVATION_DATE = 2023.08.1, (Client time - 1 month)
Then client will trigger the posting of the interest
Server will calculate the interests, there is on 2023-09-01
Testcase only expects a single interest be there, so it will PASS.
Scenario #4, Tesctase running in Asia/Kolkata, time is 2023.09.01 02:00 AM, Server is in Asia/Kolkata, so there the time is 2023.09.01 02:00 AM
Fixed Deposit Account will be created with ACTIVATION_DATE = 2023.08.1, (Client time - 1 month)
Then client will trigger the posting of the interest
Server will calculate the interests, there is on 2023-09-01
Testcase only expects a single interest be there, so it will PASS.
=> We need to make sure that client is always running using Asia/Kolkata TZ and the clock is in align with the server clock.
=> Server has a default tenant running using Asia/Kolkata TZ
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.