Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FINERACT-2181: Refactor ResultsetColumnHeaderData using Lombok and modern java new features #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 1 commit into from
Mar 10, 2025
Merged

FINERACT-2181: Refactor ResultsetColumnHeaderData using Lombok and modern java new features #4307

adamsaghy merged 1 commit into from
Mar 10, 2025

Conversation

@a7med3del1973
Copy link
Contributor

@a7med3del1973 a7med3del1973 commented Feb 6, 2025 •
edited
Loading

Description

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

adamsaghy
adamsaghy requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review the comments!

@a7med3del1973
Copy link
Contributor Author

a7med3del1973 commented Feb 9, 2025

Kindly review the comments!

@adamsaghy
Thanks for your review .. your comments are noted then refactored the code now waiting your feedback

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 9, 2025

@a7med3del1973 please squash your commits!

1 similar comment
@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 9, 2025

@a7med3del1973 please squash your commits!

@a7med3del1973
Copy link
Contributor Author

a7med3del1973 commented Feb 10, 2025 •
edited
Loading

@adamsaghy squash done

@a7med3del1973 a7med3del1973 force-pushed the lombok-integration branch 3 times, most recently from 2b77e08 to 41b4859 Compare February 10, 2025 13:25
@a7med3del1973
Copy link
Contributor Author

a7med3del1973 commented Feb 10, 2025

@adamsaghy
@oluexpert99
if your think something should be modified please let me know.

@galovics
Copy link
Contributor

galovics commented Feb 12, 2025

@a7med3del1973 what's the purpose here? are you familiar with Java and have an IDE set up properly? I really feel like you're just starting out hence the "used in SearchUtil" comments in the codebase. Also, the PR builds are failing, probably due to formatting issues (haven't checked).

@a7med3del1973
Copy link
Contributor Author

a7med3del1973 commented Feb 12, 2025

@galovics Thanks for your review
Added this comments just for clearity. Your comment noted and working on it.

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 24, 2025

@a7med3del1973 Kindly fix the failing checks:

> Task :fineract-core:modernizer
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:225:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:226:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:227:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:228:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:229:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:230:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:231:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:232:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:233:9: 'if' construct must use '{}'s. [NeedBraces]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:234:9: 'if' construct must use '{}'s. [NeedBraces]

Execution failed for task ':fineract-core:checkstyleMain'.
> A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction
   > Checkstyle rule violations were found. See the report at: file:///home/runner/work/fineract/fineract/fineract-core/build/reports/checkstyle/main.html
     Checkstyle files with violations: 1
     Checkstyle violations by severity: [error:10]

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 27, 2025

@a7med3del1973 Please make sure the PR title and commit message are following the required naming conventions: "FINERACT-XXXX: short description"

@a7med3del1973 a7med3del1973 changed the title Refactor ResultsetColumnHeaderData to Use Lombok Annotations for Boilerplate Reduction FINERACT-2081: Refactor ResultsetColumnHeaderData to Use Lombok Annotations for Boilerplate Reduction Mar 3, 2025
@a7med3del1973 a7med3del1973 changed the title FINERACT-2081: Refactor ResultsetColumnHeaderData to Use Lombok Annotations for Boilerplate Reduction FINERACT-2081: Refactor ResultsetColumnHeaderData using Lombok and modern java new features Mar 3, 2025
@adamsaghy
Copy link
Contributor

adamsaghy commented Mar 3, 2025

@a7med3del1973 FINERACT-2081 was a story to cover minor changes in 1.11. Since this version of release process started, we cannot use this story anymore. Kindly use the https://issues.apache.org/jira/browse/FINERACT-2181 from now on for minor changes which will be part of 1.12.

@a7med3del1973 a7med3del1973 changed the title FINERACT-2081: Refactor ResultsetColumnHeaderData using Lombok and modern java new features FINERACT-2181: Refactor ResultsetColumnHeaderData using Lombok and modern java new features Mar 3, 2025
@a7med3del1973
Copy link
Contributor Author

a7med3del1973 commented Mar 3, 2025

@a7med3del1973 FINERACT-2081 was a story to cover minor changes in 1.11. Since this version of release process started, we cannot use this story anymore. Kindly use the https://issues.apache.org/jira/browse/FINERACT-2181 from now on for minor changes which will be part of 1.12.

Changes done.

adamsaghy
adamsaghy requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my review...

@adamsaghy adamsaghy merged commit 8371e16 into apache:develop Mar 10, 2025
10 checks passed
@a7med3del1973 a7med3del1973 deleted the lombok-integration branch March 10, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IOhacker IOhacker IOhacker left review comments

@adamsaghy adamsaghy adamsaghy requested changes

@oluexpert99 oluexpert99 Awaiting requested review from oluexpert99

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@a7med3del1973 @adamsaghy @galovics @oluexpert99 @IOhacker