Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Pinchez25
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@Pinchez25 Pinchez25 force-pushed the fix/sms-status-reports branch from 218ff50 to 966672d Compare June 19, 2025 07:17
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test which covers correct behaviour!

@adamsaghy
Copy link
Contributor

@Pinchez25 What's up here?

@Pinchez25 Pinchez25 force-pushed the fix/sms-status-reports branch 4 times, most recently from 8e6b080 to edbb836 Compare July 21, 2025 10:14
@Pinchez25 Pinchez25 requested a review from adamsaghy July 21, 2025 10:15
@Pinchez25 Pinchez25 force-pushed the fix/sms-status-reports branch from edbb836 to 4b67627 Compare July 21, 2025 11:24
@Pinchez25 Pinchez25 force-pushed the fix/sms-status-reports branch from 4b67627 to b49fdb4 Compare July 21, 2025 12:11
@galovics galovics merged commit 00d6131 into apache:develop Jul 29, 2025
39 checks passed
@Pinchez25 Pinchez25 deleted the fix/sms-status-reports branch August 9, 2025 04:59
@Pinchez25 Pinchez25 restored the fix/sms-status-reports branch August 9, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants