Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FINERACT-2311: Add GET API for buy down fees related information #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 2 commits into from
Jul 31, 2025
Merged

FINERACT-2311: Add GET API for buy down fees related information #4882

adamsaghy merged 2 commits into from
Jul 31, 2025

Conversation

@oleksii-novikov-onix
Copy link
Contributor

@oleksii-novikov-onix oleksii-novikov-onix commented Jul 24, 2025

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@oleksii-novikov-onix oleksii-novikov-onix marked this pull request as ready for review July 24, 2025 12:52
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch 4 times, most recently from 796d613 to d91c0c2 Compare July 28, 2025 11:51
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch 2 times, most recently from 05aeabb to 2910221 Compare July 29, 2025 09:41
adamsaghy
adamsaghy requested changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look on my request!

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from 2910221 to 1b6b0b1 Compare July 29, 2025 17:06
@oleksii-novikov-onix oleksii-novikov-onix marked this pull request as draft July 29, 2025 17:11
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from ba42e39 to 7dd52f3 Compare July 30, 2025 08:59
@adamsaghy adamsaghy marked this pull request as ready for review July 30, 2025 09:00
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch 2 times, most recently from df733ac to b4cfeb5 Compare July 30, 2025 12:18
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from b4cfeb5 to a3478e4 Compare July 30, 2025 14:21
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from a3478e4 to b1b9063 Compare July 30, 2025 15:08
@adamsaghy
Copy link
Contributor

adamsaghy commented Jul 30, 2025

@oleksii-novikov-onix Please check and fix the failed tests!

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2311/buy-down-fees-fetch-amortization-details branch from b1b9063 to 086e1c5 Compare July 30, 2025 20:33
@oleksii-novikov-onix
Copy link
Contributor Author

oleksii-novikov-onix commented Jul 30, 2025

@oleksii-novikov-onix Please check and fix the failed tests!

Done

adamsaghy
adamsaghy approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 3e2684c into apache:develop Jul 31, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2311/buy-down-fees-fetch-amortization-details branch July 31, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy adamsaghy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksii-novikov-onix @adamsaghy @MarianaDmytrivBinariks