Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mariiaKraievska
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@mariiaKraievska mariiaKraievska marked this pull request as ready for review August 18, 2025 10:55
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2326/fix-user-loan-permission-tests branch from 5772058 to 3b1ff75 Compare August 18, 2025 11:39
@adamsaghy adamsaghy changed the title FINERACT-2326: Fix UserLoanPermissionTest FINERACT-2326: Merchant buy down fee flag is optional Aug 18, 2025
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 3fb9b94 into apache:develop Aug 18, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2326/fix-user-loan-permission-tests branch August 18, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants