Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release #5021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 2 commits into from
Sep 10, 2025
Merged

FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release #5021

adamsaghy merged 2 commits into from
Sep 10, 2025

Conversation

@Akshat-Soni02
Copy link

@Akshat-Soni02 Akshat-Soni02 commented Sep 8, 2025

…eases

Description

This PR updates the DockerHub publishing workflow (publish-dockerhub.yml) to improve tag naming:

  • For builds from the develop branch → publish image with the latest tag.
  • For builds from release tags (1.*) → publish image with the version number only.
  • Removes publishing of commit hashes and the develop tag.

This change makes the "Recent tags" dropdown on DockerHub more understandable for end users.

Checklist

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made. (Not applicable — workflow change only)
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes. (Not applicable — no API change)
  • Submission is not a "code dump".

@adamsaghy
Copy link
Contributor

adamsaghy commented Sep 8, 2025

@Akshat-Soni02 Please change the commit message to match with the PR title:
FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release

@Akshat-Soni02 Akshat-Soni02 force-pushed the Fineract-2350/dockerhub-tags branch from 0b94f8d to 446bb7c Compare September 8, 2025 19:38
@Akshat-Soni02
Copy link
Author

Akshat-Soni02 commented Sep 8, 2025

@Akshat-Soni02 Please change the commit message to match with the PR title: FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release

commit message updated, please take a look

@adamsaghy
Copy link
Contributor

adamsaghy commented Sep 8, 2025

@Akshat-Soni02
Execution failed for task ':spotlessMiscCheck'.

The following files had format violations:
.github/workflows/publish-dockerhub.yml
@@ -41,7 +41,7 @@
··········else
············TAGS="${{·github.ref_name·}}"
··········fi
-··········
+
··········./gradlew·--no-daemon·--console=plain·:fineract-provider:jib·-x·test·-x·cucumber·
············-Djib.to.auth.username=${{secrets.DOCKERHUB_USER}}·
············-Djib.to.auth.***
Run './gradlew :spotlessApply' to fix these violations.

@Akshat-Soni02 Akshat-Soni02 force-pushed the Fineract-2350/dockerhub-tags branch from 446bb7c to c5ad497 Compare September 10, 2025 15:45
@Akshat-Soni02
Copy link
Author

Akshat-Soni02 commented Sep 10, 2025

@Akshat-Soni02 Execution failed for task ':spotlessMiscCheck'.

The following files had format violations:
.github/workflows/publish-dockerhub.yml
@@ -41,7 +41,7 @@
··········else
············TAGS="${{·github.ref_name·}}"
··········fi
-··········
+
··········./gradlew·--no-daemon·--console=plain·:fineract-provider:jib·-x·test·-x·cucumber·
············-Djib.to.auth.username=${{secrets.DOCKERHUB_USER}}·
············-Djib.to.auth.***
Run './gradlew :spotlessApply' to fix these violations.

fixed spotless formatting

@adamsaghy adamsaghy merged commit 2ea85ea into apache:develop Sep 10, 2025
39 checks passed
@adamsaghy adamsaghy mentioned this pull request Sep 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Akshat-Soni02 @adamsaghy