FINERACT-2354: Introduce reaging preview API #5063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d5cc27 to
61b0528
Compare
Contributor
|
@oleksii-novikov-onix Please rebase. |
61b0528 to
377db88
Compare
Contributor
Author
|
2 tasks
377db88 to
ff13fb2
Compare
cbb30b1 to
3a8af86
Compare
adamsaghy
reviewed
Oct 27, 2025
...oanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 27, 2025
...oanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 27, 2025
...src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 27, 2025
...src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Oct 27, 2025
.../main/java/org/apache/fineract/portfolio/loanaccount/service/reaging/LoanReAgingService.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Oct 27, 2025
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
Please kindly see my review!
3a8af86 to
c3b04b9
Compare
5d47942 to
cc7407d
Compare
d16b458 to
568e2f3
Compare
568e2f3 to
2055a0e
Compare
Contributor
|
@oleksii-novikov-onix Please rebase |
2055a0e to
5179b33
Compare
5179b33 to
cb2a09a
Compare
cb2a09a to
0dd13c8
Compare
| | Principal due | Interest | Fees | Penalties | Due | Paid | In advance | Late | Outstanding | | ||
| | 1000.0 | 0.0 | 0.0 | 0.0 | 1000.0 | 0.0 | 0.0 | 0.0 | 1000.0 | | ||
|
|
||
| # When Loan Pay-off is made on "15 April 2025" |
Contributor
There was a problem hiding this comment.
I believe it can be uncommented, or am I missing something?
Contributor
There was a problem hiding this comment.
removed, thanks
0dd13c8 to
011006b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.