Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FINERACT-2382: Repayment schedule for Flat-Cumulative-Multi Disbursement #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsaghy merged 2 commits into from
Oct 27, 2025
Merged

FINERACT-2382: Repayment schedule for Flat-Cumulative-Multi Disbursement #5070

adamsaghy merged 2 commits into from
Oct 27, 2025

Conversation

@alberto-art3ch
Copy link
Contributor

@alberto-art3ch alberto-art3ch commented Oct 1, 2025

Description

Currently Fineract is not handling the Flat-Cumulative-Multi Disbursement configuration laan account schedule calculation correctly and has a validation at loan product level to not to allow multi disbursement if the calculation type is FLAT.

FINERACT-2382

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2326/repayment-schedule-handling-for-flat-cumulative-multi-disbursement branch 2 times, most recently from 1965256 to 2948d2a Compare October 3, 2025 04:24
@alberto-art3ch alberto-art3ch marked this pull request as ready for review October 3, 2025 21:19
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2326/repayment-schedule-handling-for-flat-cumulative-multi-disbursement branch 4 times, most recently from 7b36536 to c4df868 Compare October 13, 2025 18:22
adamsaghy
adamsaghy reviewed Oct 15, 2025
View reviewed changes
...ct-core/src/main/java/org/apache/fineract/infrastructure/core/data/DataValidatorBuilder.java Outdated
if (!intValue.equals(number)) {
String validationErrorCode = "validation.msg." + this.resource + "." + this.parameter + ".not.equal.to.specified.number";
String defaultEnglishMessage = "The parameter `" + this.parameter + "` must be same as" + number;
String defaultEnglishMessage = "The parameter `" + this.parameter + "`must be same as " + number;
Copy link
Contributor

@adamsaghy adamsaghy Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing space before the word "must":
"The parameter " + this.parameter + "must be same as " + number;
It should be:
"The parameter " + this.parameter + " must be same as " + number;, no?

Copy link
Contributor Author

@alberto-art3ch alberto-art3ch Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Space added

adamsaghy
adamsaghy requested changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alberto-art3ch I see a lot of tests were added and some validations were removed, but i dont see any changes in the business logic implementation. How this could be?

@adamsaghy
Copy link
Contributor

adamsaghy commented Oct 15, 2025

@alberto-art3ch Please rebase this PR.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2326/repayment-schedule-handling-for-flat-cumulative-multi-disbursement branch from c4df868 to 40b175e Compare October 15, 2025 15:08
@alberto-art3ch
Copy link
Contributor Author

alberto-art3ch commented Oct 15, 2025

@alberto-art3ch I see a lot of tests were added and some validations were removed, but i dont see any changes in the business logic implementation. How this could be?

The validations were added in the past and now we don't need more, so those were removed, And the change was mainly in a method to apply the principal calculation. Finally the test were added just to validate the figures expected in the spreadsheet

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2326/repayment-schedule-handling-for-flat-cumulative-multi-disbursement branch from 40b175e to b4e278a Compare October 15, 2025 15:31
adamsaghy
adamsaghy approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 54e85c7 into apache:develop Oct 27, 2025
33 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2326/repayment-schedule-handling-for-flat-cumulative-multi-disbursement branch October 27, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galovics galovics galovics approved these changes

@adamsaghy adamsaghy adamsaghy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alberto-art3ch @adamsaghy @galovics @MarianaDmytrivBinariks