Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@adamsaghy
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy adamsaghy force-pushed the FINERACT-2326/do-not-remove-external-id-if-not-replayed branch from ab23de1 to d8459e6 Compare October 8, 2025 14:27
Copy link
Contributor

@somasorosdpc somasorosdpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy force-pushed the FINERACT-2326/do-not-remove-external-id-if-not-replayed branch from d8459e6 to 97d2bb3 Compare October 8, 2025 17:22
@adamsaghy adamsaghy force-pushed the FINERACT-2326/do-not-remove-external-id-if-not-replayed branch from 97d2bb3 to e19130b Compare October 8, 2025 18:21
@adamsaghy adamsaghy merged commit ebae206 into apache:develop Oct 8, 2025
41 of 43 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2326/do-not-remove-external-id-if-not-replayed branch October 8, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants