FINERACT-2354: Second step - charge-off edge case of re-aging for Interest bearing loans - Default Behavior, interestRecalculation = true, without dueDate change #5111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cf4f7c to
6f3c422
Compare
6f3c422 to
6f693ec
Compare
6f693ec to
f5ab0e2
Compare
adamsaghy
reviewed
Oct 28, 2025
| * getDueDate()) | ||
| */ | ||
| private RepaymentPeriod findPeriodThatContainsDate(final List<RepaymentPeriod> periods, final LocalDate date) { | ||
| return periods.stream().filter(rp -> !rp.getFromDate().isAfter(date) && !rp.getDueDate().isBefore(date)).toList().getFirst(); |
Contributor
There was a problem hiding this comment.
why from date included and due date excluded?
Contributor
Author
There was a problem hiding this comment.
No longer relevant
…erest bearing loans - Default Behavior, interestRecalculation = true, without dueDate change
f5ab0e2 to
7c99d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.