FINERACT-2405: totalUnpaidPayableNotDueInterest resets to 0 on Charge-Off #5153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budaidev
reviewed
Nov 12, 2025
| | Principal due | Interest | Fees | Penalties | Due | Paid | In advance | Late | Outstanding | | ||
| | 546.14 | 24.69 | 0.0 | 10.0 | 580.83 | 308.59 | 308.59 | 0.0 | 272.24 | | ||
|
|
||
| @temp3 |
Contributor
There was a problem hiding this comment.
do we need this temp3 tag?
Contributor
Author
There was a problem hiding this comment.
Tag removed, thanks
| Double totalUnpaidPayableNotDueInterestActual = loanDetailsResponse.body().getSummary().getTotalUnpaidPayableNotDueInterest() | ||
| .doubleValue(); | ||
| assertThat(totalUnpaidPayableNotDueInterestActual) | ||
| .as(ErrorMessageHelper.wrongAmountInTotalUnpaidPayableDueInterest(totalUnpaidPayableNotDueInterestActual, |
Contributor
There was a problem hiding this comment.
This logic is a little bit strange with the naming. So the method says wrongAmountInTotalUnpaidPayableDueInterest, but we are checking totalUnpaidPayableNotDueInterestActual and totalUnpaidPayableNotDueInterestExpected. Which one are we actually checking?
Contributor
Author
There was a problem hiding this comment.
Method renamed to be more easy to understand the amount to be validated
ruzeynalov
approved these changes
Nov 12, 2025
1837481 to
f432d67
Compare
adamsaghy
reviewed
Nov 18, 2025
| @Override | ||
| public BigDecimal computeTotalUnpaidPayableDueInterestAmount(Collection<LoanSchedulePeriodData> periods, final LocalDate businessDate) { | ||
| return periods.stream().filter(period -> !period.isDownPaymentPeriod() && !businessDate.isBefore(period.getDueDate())) | ||
| return periods.stream().filter(period -> !period.isDownPaymentPeriod() && !period.getDueDate().isAfter(businessDate)) |
Contributor
There was a problem hiding this comment.
@alberto-art3ch This cannot be right... on the due date it shall be part of the unpaid, payable, due interest amount.
adamsaghy
reviewed
Nov 18, 2025
| if (loan.isChargedOff() || loan.hasContractTerminationTransaction()) { | ||
| if (loan.isChargedOff()) { | ||
| return currentRepaymentPeriod.get().getInterestOutstanding(loan.getCurrency()).getAmount(); | ||
| } else if (loan.hasContractTerminationTransaction()) { |
Contributor
There was a problem hiding this comment.
@alberto-art3ch I think the same shall apply to contract termination. Charge-off and Contract termination is quite similar in this case.
adamsaghy
requested changes
Nov 18, 2025
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
Please see my questions.
20714a3 to
cf1aa62
Compare
f082afe to
5a775c1
Compare
5a775c1 to
66d7145
Compare
66d7145 to
5d328c9
Compare
adamsaghy
approved these changes
Nov 19, 2025
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were having an issue where the
totalUnpaidPayableNotDueInterestin summary gets reset to 0 when a loan is charged off even though there were unrealized accruals available in that installment.FINERACT-2405
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.