Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FINERACT-2411: Allow empty columns to be deleted from datatables #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
galovics merged 1 commit into from
Nov 26, 2025
Merged

FINERACT-2411: Allow empty columns to be deleted from datatables #5174

galovics merged 1 commit into from
Nov 26, 2025

Conversation

@rhopman
Copy link
Contributor

@rhopman rhopman commented Nov 24, 2025

Description

Allow a column to be dropped from a datatable if the column is currently NULL for all records.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@rhopman rhopman force-pushed the FINERACT-2411-allow-empty-columns-to-be-deleted-from-datatables branch from 6dc3f14 to 1c3017d Compare November 25, 2025 08:08
@rhopman rhopman marked this pull request as draft November 25, 2025 08:56
@rhopman rhopman force-pushed the FINERACT-2411-allow-empty-columns-to-be-deleted-from-datatables branch from 1c3017d to d742b0d Compare November 25, 2025 09:48
@rhopman rhopman marked this pull request as ready for review November 25, 2025 09:48
@rhopman rhopman marked this pull request as draft November 25, 2025 09:51
@rhopman rhopman force-pushed the FINERACT-2411-allow-empty-columns-to-be-deleted-from-datatables branch 2 times, most recently from ca52bae to 4792eff Compare November 25, 2025 09:54
@rhopman rhopman marked this pull request as ready for review November 25, 2025 09:55
@adamsaghy
Copy link
Contributor

adamsaghy commented Nov 25, 2025

@rhopman Please run this to fix the spotless related issues:

./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest

@rhopman rhopman force-pushed the FINERACT-2411-allow-empty-columns-to-be-deleted-from-datatables branch from 4792eff to fee6d86 Compare November 25, 2025 15:02
@rhopman
Copy link
Contributor Author

rhopman commented Nov 25, 2025

Apologies @adamsaghy, I thought I did all the checks but apparently I missed this. It should be fixed now.

@galovics galovics merged commit a9d5307 into apache:develop Nov 26, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galovics galovics galovics approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhopman @adamsaghy @galovics