[VL] Respect orc.force.positional.evolution#12234
Open
beliefer wants to merge 4 commits into
Open
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
wForget
reviewed
Jun 4, 2026
wForget
approved these changes
Jun 5, 2026
|
Run Gluten Clickhouse CI on x86 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Gluten’s Velox ORC read path so that the effective ORC column-mapping behavior respects the Hadoop/Spark config spark.hadoop.orc.force.positional.evolution (i.e., forces positional mapping even when orcUseColumnNames would otherwise be true), aligning behavior with vanilla Spark.
Changes:
- Add
spark.hadoop.orc.force.positional.evolutionhandling and use it to override the Velox native session settingspark.gluten.sql.columnar.backend.velox.orcUseColumnNames=false. - Update
VeloxConfig.orcUseColumnNamesto incorporateorc.force.positional.evolution. - Add a regression test asserting the new effective behavior via fallback behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala | Adds orc.force.positional.evolution config constants and forces the native Velox session conf to positional mapping when enabled. |
| backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala | Makes JVM-side orcUseColumnNames effectively false when positional evolution is forced. |
| backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala | Adds a test case to validate the new “force positional evolution” interaction with orcUseColumnNames. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR proposes to respect
orc.force.positional.evolutionwhile reading ORC files.Fixes #12232
How was this patch tested?
Add new tests.
Manual test on our production environment.
Was this patch authored or co-authored using generative AI tooling?
'Yes'.