Add getTotalCount() tests for sorting parameters #1758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for consistency with the test for the criteria.
This is to check that a getTotalCount() implementation should not have sorting in the generated query. Otherwise, depending on the database and its strictness configuration, the query might fail.
|
|
Contributor
Author
|
@puneetbehl When merging this, please also back port it to |
Contributor
|
Can you please cherry-pick and send a PR to 7.3.x branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to check that a
getTotalCount()implementation should not have sorting in the generated query.Otherwise, depending on the database and its strictness configuration, the query might fail.
In the gorm-hibernate5 project one test would fail a follows:
I will also provide a fix for it.