Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HBASE-29272 When Spark reads an HBase snapshot, it always read empty … #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HBASE-29272 When Spark reads an HBase snapshot, it always read empty … #6947

wants to merge 2 commits into from
+202 −6

Conversation

terrytlu
Copy link
Contributor

Fix the issue that after Spark 3.2.0, when Spark reads an HBase snapshot, it always read empty, even if the hbase snapshot actually has data.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@terrytlu terrytlu force-pushed the master-HBASE-29272 branch 3 times, most recently from a96d09e to 5e35c8d Compare April 29, 2025 13:17
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@terrytlu terrytlu force-pushed the master-HBASE-29272 branch from 5e35c8d to 79c6087 Compare May 7, 2025 08:13
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 18s master passed
+1 💚 compile 1m 18s master passed
+1 💚 javadoc 0m 41s master passed
+1 💚 shadedjars 5m 56s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 41s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 18s /patch-compile-hbase-mapreduce.txt hbase-mapreduce in the patch failed.
-0 ⚠️ javac 0m 18s /patch-compile-hbase-mapreduce.txt hbase-mapreduce in the patch failed.
-0 ⚠️ javadoc 0m 14s /results-javadoc-javadoc-hbase-mapreduce.txt hbase-mapreduce generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 ❌ shadedjars 4m 34s patch has 11 errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 0m 58s /patch-unit-hbase-server.txt hbase-server in the patch failed.
-1 ❌ unit 0m 17s /patch-unit-hbase-mapreduce.txt hbase-mapreduce in the patch failed.
22m 26s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6947/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6947
Optional Tests javac javadoc unit compile shadedjars
uname Linux a6bfec21bd87 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef505d5
Default Java Eclipse Adoptium-17.0.11+9
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6947/5/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6947/5/testReport/
Max. process+thread count 75 (vs. ulimit of 30000)
modules C: hbase-server hbase-mapreduce U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6947/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 5s master passed
+1 💚 compile 3m 43s master passed
+1 💚 checkstyle 0m 46s master passed
+1 💚 spotbugs 2m 4s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 41s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 17s /patch-compile-hbase-mapreduce.txt hbase-mapreduce in the patch failed.
-0 ⚠️ javac 0m 17s /patch-compile-hbase-mapreduce.txt hbase-mapreduce in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 36s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
-1 ❌ spotbugs 0m 16s /patch-spotbugs-hbase-mapreduce.txt hbase-mapreduce in the patch failed.
-1 ❌ hadoopcheck 2m 0s The patch causes 11 errors with Hadoop v3.3.6.
-1 ❌ hadoopcheck 4m 2s The patch causes 11 errors with Hadoop v3.4.0.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
25m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6947/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6947
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 1489a5498d9c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ef505d5
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6947/5/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6947/5/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server hbase-mapreduce U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6947/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

guluo2016
guluo2016 reviewed May 7, 2025
View reviewed changes
...-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java

// constructor for mapreduce framework / Writable
public InputSplit() {
}

public InputSplit(TableDescriptor htd, RegionInfo regionInfo, List<String> locations, Scan scan,
Path restoreDir) {
this(htd, regionInfo, locations, scan, restoreDir, 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem quite right in here, because SnapShotStats.getStoreFilesSize() would return 0 if the table has no any data.
What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing 😃 , it shouldn't always be 1 here, let me try to fix it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guluo2016 guluo2016 guluo2016 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrytlu @Apache-HBase @guluo2016