update(store): fix some potential lock & type cast issues#2895
Merged
imbajin merged 2 commits intoapache:masterfrom Oct 31, 2025
Merged
update(store): fix some potential lock & type cast issues#2895imbajin merged 2 commits intoapache:masterfrom
imbajin merged 2 commits intoapache:masterfrom
Conversation
dc14394 to
a451b55
Compare
a451b55 to
4066062
Compare
Pengzna
previously approved these changes
Oct 31, 2025
- chore(store): clean some comments - chore(store): using Slf4j instead of System.out to print log - update(store): update more reasonable timeout setting - update(store): add close method for CopyOnWriteCache to avoid potential memory leak - update(store): delete duplicated beginTx() statement - update(store): extract parameter for compaction thread pool(move to configuration file in the future) - update(store): add default logic in AggregationFunctions - update(store): fix potential concurrency problem in QueryExecutor
4066062 to
016d235
Compare
imbajin
previously approved these changes
Oct 31, 2025
Pengzna
requested changes
Oct 31, 2025
...g-store-common/src/main/java/org/apache/hugegraph/store/query/func/AggregationFunctions.java
Outdated
Show resolved
Hide resolved
…raph/store/query/func/AggregationFunctions.java
Pengzna
approved these changes
Oct 31, 2025
imbajin
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need